mmc: mmc_test: Use kcalloc() in mmc_test_alloc_mem()
authorMarkus Elfring <elfring@users.sourceforge.net>
Sun, 8 Jan 2017 20:43:12 +0000 (21:43 +0100)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 13 Feb 2017 12:20:11 +0000 (13:20 +0100)
* The script "checkpatch.pl" pointed information out like the following.

  WARNING: Prefer kcalloc over kzalloc with multiply

  Thus fix the affected source code place.

* Replace the specification of a data structure by a pointer dereference
  to make the corresponding size determination a bit safer according to
  the Linux coding style convention.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/core/mmc_test.c

index 7784cce..d350bd6 100644 (file)
@@ -360,8 +360,7 @@ static struct mmc_test_mem *mmc_test_alloc_mem(unsigned long min_sz,
        if (!mem)
                return NULL;
 
-       mem->arr = kzalloc(sizeof(struct mmc_test_pages) * max_segs,
-                          GFP_KERNEL);
+       mem->arr = kcalloc(max_segs, sizeof(*mem->arr), GFP_KERNEL);
        if (!mem->arr)
                goto out_free;