ksmbd: Prevent integer overflow in calculation of deadtime

commit a93ff742820f75bf8bb3fcf21d9f25ca6eb3d4c6 upstream.

The user can set any value for 'deadtime'. This affects the arithmetic
expression 'req->deadtime * SMB_ECHO_INTERVAL', which is subject to
overflow. The added check makes the server behavior more predictable.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Fixes: 0626e6641f6b ("cifsd: add server handler for central processing and tranport layers")
Cc: stable@vger.kernel.org
Signed-off-by: Denis Arefev <arefev@swemel.ru>
Acked-by: Namjae Jeon <linkinjeon@kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/fs/smb/server/transport_ipc.c b/fs/smb/server/transport_ipc.c
index 87af57cf35a157215078aae94c76baf0fd81dd7c..9b3c68014aee2813ec325d37ceef6fc0800211fc 100644 (file)
--- a/fs/smb/server/transport_ipc.c
+++ b/fs/smb/server/transport_ipc.c
@@ -310,7 +310,11 @@ static int ipc_server_config_on_startup(struct ksmbd_startup_request *req)
        server_conf.signing = req->signing;
        server_conf.tcp_port = req->tcp_port;
        server_conf.ipc_timeout = req->ipc_timeout * HZ;
-       server_conf.deadtime = req->deadtime * SMB_ECHO_INTERVAL;
+       if (check_mul_overflow(req->deadtime, SMB_ECHO_INTERVAL,
+                                       &server_conf.deadtime)) {
+               ret = -EINVAL;
+               goto out;
+       }
        server_conf.share_fake_fscaps = req->share_fake_fscaps;
        ksmbd_init_domain(req->sub_auth);
 
@@ -336,6 +340,7 @@ static int ipc_server_config_on_startup(struct ksmbd_startup_request *req)
        ret |= ksmbd_set_work_group(req->work_group);
        ret |= ksmbd_tcp_set_interfaces(KSMBD_STARTUP_CONFIG_INTERFACES(req),
                                        req->ifc_list_sz);
+out:
        if (ret) {
                pr_err("Server configuration error: %s %s %s\n",
                       req->netbios_name, req->server_string,