crypto: octeontx2 - Use swap() instead of swap_engines()
authorJiapeng Chong <jiapeng.chong@linux.alibaba.com>
Thu, 16 Dec 2021 07:48:14 +0000 (15:48 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 24 Dec 2021 03:18:22 +0000 (14:18 +1100)
Fix the following coccicheck warning:

./drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c:1523:16-17:
WARNING opportunity for swap().

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/marvell/octeontx2/otx2_cptpf_ucode.c

index 57307ea..9aef379 100644 (file)
@@ -1514,16 +1514,6 @@ delete_grps:
        return ret;
 }
 
-static void swap_engines(struct otx2_cpt_engines *engsl,
-                        struct otx2_cpt_engines *engsr)
-{
-       struct otx2_cpt_engines engs;
-
-       engs = *engsl;
-       *engsl = *engsr;
-       *engsr = engs;
-}
-
 int otx2_cpt_dl_custom_egrp_create(struct otx2_cptpf_dev *cptpf,
                                   struct devlink_param_gset_ctx *ctx)
 {
@@ -1624,7 +1614,7 @@ int otx2_cpt_dl_custom_egrp_create(struct otx2_cptpf_dev *cptpf,
                }
                /* Keep SE engines at zero index */
                if (engs[1].type == OTX2_CPT_SE_TYPES)
-                       swap_engines(&engs[0], &engs[1]);
+                       swap(engs[0], engs[1]);
        }
        mutex_lock(&eng_grps->lock);