scsi: 53c700: Open-code status_byte(u8) calls
authorBart Van Assche <bvanassche@acm.org>
Thu, 15 Apr 2021 22:08:20 +0000 (15:08 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 16 Apr 2021 02:44:41 +0000 (22:44 -0400)
The 53c700 driver is one of the two drivers that passes an u8 argument to
status_byte() instead of an s32 argument. Open-code status_byte in
preparation of changing SCSI status values into a structure.

Link: https://lore.kernel.org/r/20210415220826.29438-15-bvanassche@acm.org
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/53c700.c

index 4fd91f8..ab42fea 100644 (file)
@@ -981,8 +981,8 @@ process_script_interrupt(__u32 dsps, __u32 dsp, struct scsi_cmnd *SCp,
                                                  NCR_700_FINISHED_TAG_NEGOTIATION);
                        
                /* check for contingent allegiance conditions */
-               if(status_byte(hostdata->status[0]) == CHECK_CONDITION ||
-                  status_byte(hostdata->status[0]) == COMMAND_TERMINATED) {
+               if (hostdata->status[0] >> 1 == CHECK_CONDITION ||
+                   hostdata->status[0] >> 1 == COMMAND_TERMINATED) {
                        struct NCR_700_command_slot *slot =
                                (struct NCR_700_command_slot *)SCp->host_scribble;
                        if(slot->flags == NCR_700_FLAG_AUTOSENSE) {