fs: ext4: fix files seen as symlink during deletion

The deletion process handles special case for symlinks whose target are
small enough that it fits in struct ext2_inode.b.symlink. So no block had
been allocated. But the check of file type wrongly considered regular
files as symlink. So, no block was freed. So, the EXT4 partition could be
corrupted because of no free block available.

Signed-off-by: Corentin GUILLEVIC <corentin.guillevic@smile.fr>

diff --git a/fs/ext4/ext4_write.c b/fs/ext4/ext4_write.c
index f22af45..ea4c5d4 100644 (file)
--- a/fs/ext4/ext4_write.c
+++ b/fs/ext4/ext4_write.c
@@ -473,7 +473,7 @@ static int ext4fs_delete_file(int inodeno)
         * special case for symlinks whose target are small enough that
         *it fits in struct ext2_inode.b.symlink: no block had been allocated
         */
-       if ((le16_to_cpu(inode.mode) & S_IFLNK) &&
+       if (S_ISLNK(le16_to_cpu(inode.mode)) &&
            le32_to_cpu(inode.size) <= sizeof(inode.b.symlink)) {
                no_blocks = 0;
        }