NFSD: Replace READ* macros that decode the fattr4 owner_group attribute
authorChuck Lever <chuck.lever@oracle.com>
Thu, 19 Nov 2020 18:58:18 +0000 (13:58 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 30 Nov 2020 19:46:36 +0000 (14:46 -0500)
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c

index 903b4db..433fa67 100644 (file)
@@ -374,11 +374,16 @@ nfsd4_decode_fattr(struct nfsd4_compoundargs *argp, u32 *bmval,
                iattr->ia_valid |= ATTR_UID;
        }
        if (bmval[1] & FATTR4_WORD1_OWNER_GROUP) {
-               READ_BUF(4);
-               dummy32 = be32_to_cpup(p++);
-               READ_BUF(dummy32);
-               READMEM(buf, dummy32);
-               if ((status = nfsd_map_name_to_gid(argp->rqstp, buf, dummy32, &iattr->ia_gid)))
+               u32 length;
+
+               if (xdr_stream_decode_u32(argp->xdr, &length) < 0)
+                       return nfserr_bad_xdr;
+               p = xdr_inline_decode(argp->xdr, length);
+               if (!p)
+                       return nfserr_bad_xdr;
+               status = nfsd_map_name_to_gid(argp->rqstp, (char *)p, length,
+                                             &iattr->ia_gid);
+               if (status)
                        return status;
                iattr->ia_valid |= ATTR_GID;
        }