mt76: mt7915: fix info leak in mt7915_mcu_set_pre_cal()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 25 Jun 2021 14:58:54 +0000 (17:58 +0300)
committerFelix Fietkau <nbd@nbd.name>
Wed, 20 Oct 2021 08:36:23 +0000 (10:36 +0200)
Zero out all the unused members of "req" so that we don't disclose
stack information.

Fixes: 495184ac91bb ("mt76: mt7915: add support for applying pre-calibration data")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Felix Fietkau <nbd@nbd.name>
Signed-off-by: Felix Fietkau <nbd@nbd.name>
drivers/net/wireless/mediatek/mt76/mt7915/mcu.c

index 4396077..dfb6f17 100644 (file)
@@ -3481,7 +3481,7 @@ static int mt7915_mcu_set_pre_cal(struct mt7915_dev *dev, u8 idx,
                u8 idx;
                u8 rsv[4];
                __le32 len;
-       } req;
+       } req = {};
        struct sk_buff *skb;
 
        skb = mt76_mcu_msg_alloc(&dev->mt76, NULL, sizeof(req) + len);