NFSD: Replace READ* macros in nfsd4_decode_read()
authorChuck Lever <chuck.lever@oracle.com>
Tue, 3 Nov 2020 19:28:24 +0000 (14:28 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Mon, 30 Nov 2020 19:46:39 +0000 (14:46 -0500)
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/nfs4xdr.c

index f28bebd..8982f27 100644 (file)
@@ -1218,16 +1218,17 @@ nfsd4_decode_putpubfh(struct nfsd4_compoundargs *argp, void *p)
 static __be32
 nfsd4_decode_read(struct nfsd4_compoundargs *argp, struct nfsd4_read *read)
 {
-       DECODE_HEAD;
+       __be32 status;
 
-       status = nfsd4_decode_stateid(argp, &read->rd_stateid);
+       status = nfsd4_decode_stateid4(argp, &read->rd_stateid);
        if (status)
                return status;
-       READ_BUF(12);
-       p = xdr_decode_hyper(p, &read->rd_offset);
-       read->rd_length = be32_to_cpup(p++);
+       if (xdr_stream_decode_u64(argp->xdr, &read->rd_offset) < 0)
+               return nfserr_bad_xdr;
+       if (xdr_stream_decode_u32(argp->xdr, &read->rd_length) < 0)
+               return nfserr_bad_xdr;
 
-       DECODE_TAIL;
+       return nfs_ok;
 }
 
 static __be32