staging: fsl-dpaa2/ethsw: use bool when encoding learning/flooding state

Use a bool instead of an u8 in ethsw_set_learning() and
ethsw_port_set_flood() to encode an binary type property.

Reported-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Link: https://lore.kernel.org/r/1565700187-16048-6-git-send-email-ioana.ciornei@nxp.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
index 9ade739..20519af 100644 (file)
--- a/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
+++ b/drivers/staging/fsl-dpaa2/ethsw/ethsw.c
@@ -149,12 +149,12 @@ static int ethsw_port_add_vlan(struct ethsw_port_priv *port_priv,
        return 0;
 }
 
-static int ethsw_set_learning(struct ethsw_core *ethsw, u8 flag)
+static int ethsw_set_learning(struct ethsw_core *ethsw, bool enable)
 {
        enum dpsw_fdb_learning_mode learn_mode;
        int err;
 
-       if (flag)
+       if (enable)
                learn_mode = DPSW_FDB_LEARNING_MODE_HW;
        else
                learn_mode = DPSW_FDB_LEARNING_MODE_DIS;
@@ -165,24 +165,24 @@ static int ethsw_set_learning(struct ethsw_core *ethsw, u8 flag)
                dev_err(ethsw->dev, "dpsw_fdb_set_learning_mode err %d\n", err);
                return err;
        }
-       ethsw->learning = !!flag;
+       ethsw->learning = enable;
 
        return 0;
 }
 
-static int ethsw_port_set_flood(struct ethsw_port_priv *port_priv, u8 flag)
+static int ethsw_port_set_flood(struct ethsw_port_priv *port_priv, bool enable)
 {
        int err;
 
        err = dpsw_if_set_flooding(port_priv->ethsw_data->mc_io, 0,
                                   port_priv->ethsw_data->dpsw_handle,
-                                  port_priv->idx, flag);
+                                  port_priv->idx, enable);
        if (err) {
                netdev_err(port_priv->netdev,
                           "dpsw_if_set_flooding err %d\n", err);
                return err;
        }
-       port_priv->flood = !!flag;
+       port_priv->flood = enable;
 
        return 0;
 }