net: ipa: use sysfs_emit() to instead of scnprintf()
authorye xingchen <ye.xingchen@zte.com.cn>
Fri, 2 Dec 2022 08:42:14 +0000 (16:42 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 5 Dec 2022 11:03:49 +0000 (11:03 +0000)
Follow the advice of the Documentation/filesystems/sysfs.rst and show()
should only use sysfs_emit() or sysfs_emit_at() when formatting the
value to be returned to user space.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Reviewed-by: Alex Elder <elder@linaro.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ipa/ipa_sysfs.c

index 5cbc15a..14bd2f9 100644 (file)
@@ -46,7 +46,7 @@ version_show(struct device *dev, struct device_attribute *attr, char *buf)
 {
        struct ipa *ipa = dev_get_drvdata(dev);
 
-       return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_version_string(ipa));
+       return sysfs_emit(buf, "%s\n", ipa_version_string(ipa));
 }
 
 static DEVICE_ATTR_RO(version);
@@ -70,7 +70,7 @@ static ssize_t rx_offload_show(struct device *dev,
 {
        struct ipa *ipa = dev_get_drvdata(dev);
 
-       return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_offload_string(ipa));
+       return sysfs_emit(buf, "%s\n", ipa_offload_string(ipa));
 }
 
 static DEVICE_ATTR_RO(rx_offload);
@@ -80,7 +80,7 @@ static ssize_t tx_offload_show(struct device *dev,
 {
        struct ipa *ipa = dev_get_drvdata(dev);
 
-       return scnprintf(buf, PAGE_SIZE, "%s\n", ipa_offload_string(ipa));
+       return sysfs_emit(buf, "%s\n", ipa_offload_string(ipa));
 }
 
 static DEVICE_ATTR_RO(tx_offload);