Removing compilation warnings in wrt-installer repo

[Issue#] LINUXWRT-8
[Problem] Compilation warnings in build log.
[Cause] N/A
[Solution] N/A
[Verification] Build wrt-installer and check log for warnings.
It should be without warnings.

Change-Id: I3ac17976dead309641037b6eae68523205b4a442

diff --git a/src/configuration_parser/widget_parser.cpp b/src/configuration_parser/widget_parser.cpp
index 5f0d6ca..8f878c6 100644 (file)
--- a/src/configuration_parser/widget_parser.cpp
+++ b/src/configuration_parser/widget_parser.cpp
@@ -1363,7 +1363,7 @@ class AppControlParser : public ElementParser
         }
     }
 
-    virtual void Accept(const XmlAttribute& attribute)
+    virtual void Accept(const XmlAttribute& /*attribute*/)
     {}
 
     virtual void Accept(const Element& element)
@@ -1445,7 +1445,7 @@ class ApplicationParser : public ElementParser
         return &IgnoringParser::Create;
     }
 
-    virtual void Accept(const Text& text)
+    virtual void Accept(const Text& /*text*/)
     {
         if (m_properNamespace) {
             LogDebug("text");
@@ -1539,7 +1539,7 @@ class SplashParser : public ElementParser
         }
     }
 
-    virtual void Accept(const Element& element)
+    virtual void Accept(const Element& /*element*/)
     {}
 
     virtual void Accept(const Text& /*text*/)
@@ -1614,7 +1614,7 @@ class PrivilegeParser : public ElementParser
 {
   public:
     virtual ActionFunc GetElementParser(const DPL::String& /*ns*/,
-                                        const DPL::String& name)
+                                        const DPL::String& /*name*/)
     {
         return &IgnoringParser::Create;
     }
@@ -1752,7 +1752,7 @@ class LiveboxParser : public ElementParser
             return &IgnoringParser::Create;
         }
 
-        virtual void Accept(const XmlAttribute& attribute)
+        virtual void Accept(const XmlAttribute& /*attribute*/)
         {}
 
         virtual void Accept(const Element& element)
@@ -1893,7 +1893,7 @@ class LiveboxParser : public ElementParser
         struct PdParser : public ElementParser
         {
             virtual ActionFunc GetElementParser(const DPL::String& /*ns*/,
-                                                const DPL::String& name)
+                                                const DPL::String& /*name*/)
             {
                 return &IgnoringParser::Create;
             }
@@ -2108,8 +2108,8 @@ class LiveboxParser : public ElementParser
 class CspParser : public ElementParser
 {
   public:
-    virtual ActionFunc GetElementParser(const DPL::String& ns,
-                                        const DPL::String& name)
+    virtual ActionFunc GetElementParser(const DPL::String& /*ns*/,
+                                        const DPL::String& /*name*/)
     {
         return &IgnoringParser::Create;
     }
@@ -2127,7 +2127,7 @@ class CspParser : public ElementParser
         }
     }
 
-    virtual void Accept(const XmlAttribute& attribute)
+    virtual void Accept(const XmlAttribute& /*attribute*/)
     {}
 
     virtual void Accept(const Text& text)

diff --git a/src/jobs/job.cpp b/src/jobs/job.cpp
index ec56d3d..e65f46b 100644 (file)
--- a/src/jobs/job.cpp
+++ b/src/jobs/job.cpp
@@ -95,7 +95,7 @@ void Job::SendFinishedSuccess()
 void Job::SendFinishedFailure()
 {}
 
-void Job::SendProgressIconPath(const std::string &path)
+void Job::SendProgressIconPath(const std::string &/*path*/)
 {}
 
 void Job::SaveExceptionData(const Jobs::JobExceptionBase&)

diff --git a/src/jobs/widget_install/task_certify.cpp b/src/jobs/widget_install/task_certify.cpp
index 342b5f4..578e88c 100644 (file)
--- a/src/jobs/widget_install/task_certify.cpp
+++ b/src/jobs/widget_install/task_certify.cpp
@@ -99,8 +99,8 @@ namespace Jobs {
 namespace WidgetInstall {
 TaskCertify::TaskCertify(InstallerContext &inCont) :
     DPL::TaskDecl<TaskCertify>(this),
-    m_contextData(inCont),
-    WidgetInstallPopup(inCont)
+    WidgetInstallPopup(inCont),
+    m_contextData(inCont)
 {
     AddStep(&TaskCertify::stepSignature);
 

diff --git a/src/jobs/widget_install/task_encrypt_resource.cpp b/src/jobs/widget_install/task_encrypt_resource.cpp
index a7483f0..7d3b5ff 100644 (file)
--- a/src/jobs/widget_install/task_encrypt_resource.cpp
+++ b/src/jobs/widget_install/task_encrypt_resource.cpp
@@ -241,7 +241,8 @@ void TaskEncryptResource::EncryptFile(const std::string &fileName)
         LogDebug("Encrypt file: " << fileName);
         std::string encFile = fileName + ".enc";
 
-        struct stat info = {0};
+        struct stat info;
+        memset(&info, 0, sizeof(info));
         if (stat(fileName.c_str(), &info) != 0)
         {
             int error = errno;

diff --git a/src/jobs/widget_install/task_file_manipulation.cpp b/src/jobs/widget_install/task_file_manipulation.cpp
index fddd770..4d8c669 100644 (file)
--- a/src/jobs/widget_install/task_file_manipulation.cpp
+++ b/src/jobs/widget_install/task_file_manipulation.cpp
@@ -59,7 +59,7 @@ bool _FolderCopy(std::string source, std::string dest)
     struct dirent* dEntry = NULL;
     do {
         struct stat statInfo;
-        if (dEntry = readdir(dir)) {
+        if ((dEntry = readdir(dir)) != NULL) {
             std::string fileName = dEntry->d_name;
             std::string fullName = source + "/" + fileName;
 

diff --git a/src/jobs/widget_install/task_install_ospsvc.cpp b/src/jobs/widget_install/task_install_ospsvc.cpp
index 3fe94ef..7909c26 100644 (file)
--- a/src/jobs/widget_install/task_install_ospsvc.cpp
+++ b/src/jobs/widget_install/task_install_ospsvc.cpp
@@ -69,7 +69,15 @@ void TaskInstallOspsvc::StepInstallOspService()
                  "Error occurs during\
                 install osp service");
     }
-    fgets(readBuf, MAX_BUF_SIZE, fd);
+
+    if (fgets(readBuf, MAX_BUF_SIZE, fd) == NULL)
+    {
+        LogError("Failed to installtion osp service.\
+                Inability of reading file.");
+        ThrowMsg(Exceptions::InstallOspsvcFailed,
+                "Error occurs during\
+                install osp service");
+    }
     LogDebug("return value : " << readBuf);
 
     int result = atoi(readBuf);

diff --git a/src/jobs/widget_install/task_manifest_file.cpp b/src/jobs/widget_install/task_manifest_file.cpp
index 298a06d..a6ba63d 100644 (file)
--- a/src/jobs/widget_install/task_manifest_file.cpp
+++ b/src/jobs/widget_install/task_manifest_file.cpp
@@ -133,11 +133,20 @@ void TaskManifestFile::stepCreateExecFile()
     std::string clientExeStr = GlobalConfig::GetWrtClientExec();
 
     LogInfo("link -s " << clientExeStr << " " << exec);
-    symlink(clientExeStr.c_str(), exec.c_str());
 
+    errno = 0;
+    if (symlink(clientExeStr.c_str(), exec.c_str()) !=  0)
+    {
+        int error = errno;
+        if(error)
+            LogPedantic("Failed to make a symbolic name for a file "
+                    << "[" <<  DPL::GetErrnoString(error) << "]");
+        ThrowMsg(Exceptions::InstallationFailed,
+                "Symbolic link creating is not done.");
+    }
     m_context.job->UpdateProgress(
-        InstallerContext::INSTALL_CREATE_EXECFILE,
-        "Widget execfile creation Finished");
+            InstallerContext::INSTALL_CREATE_EXECFILE,
+            "Widget execfile creation Finished");
 }
 
 void TaskManifestFile::stepCopyIconFiles()
@@ -375,9 +384,9 @@ void TaskManifestFile::updateAilInfo()
     ail_appinfo_h ai = NULL;
     ail_error_e ret;
 
-    ret = ail_package_get_appinfo(appid, &ai);
+    ret = ail_get_appinfo(appid, &ai);
     if (ai) {
-        ail_package_destroy_appinfo(ai);
+        ail_destroy_appinfo(ai);
     }
 
     if (AIL_ERROR_NO_DATA == ret) {

diff --git a/src/jobs/widget_install/task_smack.cpp b/src/jobs/widget_install/task_smack.cpp
index 5bbb173..75d0fc8 100644 (file)
--- a/src/jobs/widget_install/task_smack.cpp
+++ b/src/jobs/widget_install/task_smack.cpp
@@ -65,5 +65,6 @@ void TaskSmack::Step()
         "Widget SMACK Enabled");
 #endif
 }
+
 } //namespace WidgetInstall
 } //namespace Jobs

diff --git a/src/jobs/widget_install/task_update_files.cpp b/src/jobs/widget_install/task_update_files.cpp
index bcbd2f3..e3fabf0 100644 (file)
--- a/src/jobs/widget_install/task_update_files.cpp
+++ b/src/jobs/widget_install/task_update_files.cpp
@@ -244,8 +244,17 @@ void TaskUpdateFiles::StepExecFileBackup()
     std::string clientPath = GlobalConfig::GetWrtClientExec();
 
     LogInfo("link -s " << clientPath << " " << execFile);
-    symlink(clientPath.c_str(), execFile.c_str());
 
+    errno = 0;
+    if( symlink(clientPath.c_str(), execFile.c_str()) != 0 )
+    {
+        int error = errno;
+        if(error)
+            LogPedantic("Failed to make a symbolic name for a file "
+                    << "[" <<  DPL::GetErrnoString(error) << "]");
+        ThrowMsg(Exceptions::BackupFailed,
+                "Error occurs during rename file");
+    }
     m_context.job->UpdateProgress(
         InstallerContext::INSTALL_BACKUP_EXEC,
         "Backup execution file for update");

diff --git a/src/jobs/widget_uninstall/task_delete_certificates.cpp b/src/jobs/widget_uninstall/task_delete_certificates.cpp
index 859bcc1..cb9b7e9 100644 (file)
--- a/src/jobs/widget_uninstall/task_delete_certificates.cpp
+++ b/src/jobs/widget_uninstall/task_delete_certificates.cpp
@@ -42,11 +42,8 @@ TaskDeleteCertificates::~TaskDeleteCertificates()
 
 void TaskDeleteCertificates::StepDeleteCertificates()
 {
-    pkgmgr_instcertinfo_h handle;
-
     if ((pkgmgr_installer_delete_certinfo(
-             const_cast<char*>((
-                                   m_context.tzAppid).c_str()))) < 0)
+             const_cast<char*>((m_context.tzAppid).c_str()))) < 0)
     {
         LogError("pkgmgr_installer_delete_certinfo fail");
     }

diff --git a/src/jobs/widget_uninstall/task_remove_files.cpp b/src/jobs/widget_uninstall/task_remove_files.cpp
index 5f66122..ac26deb 100644 (file)
--- a/src/jobs/widget_uninstall/task_remove_files.cpp
+++ b/src/jobs/widget_uninstall/task_remove_files.cpp
@@ -106,9 +106,9 @@ void TaskRemoveFiles::StepRemoveDesktop()
     const char* package = m_context.tzAppid.c_str();
     LogDebug("ail delete : " << package);
 
-    ret = ail_package_get_appinfo(package, &ai);
+    ret = ail_get_appinfo(package, &ai);
     if (ai) {
-        ail_package_destroy_appinfo(ai);
+        ail_destroy_appinfo(ai);
     }
 
     if (AIL_ERROR_OK == ret) {

diff --git a/src/jobs/widget_uninstall/task_uninstall_ospsvc.cpp b/src/jobs/widget_uninstall/task_uninstall_ospsvc.cpp
index 5d99a11..572b130 100644 (file)
--- a/src/jobs/widget_uninstall/task_uninstall_ospsvc.cpp
+++ b/src/jobs/widget_uninstall/task_uninstall_ospsvc.cpp
@@ -64,7 +64,15 @@ void TaskUninstallOspsvc::StepUninstallOspsvc()
                  "Error occurs during\
                 uninstall osp service");
     }
-    fgets(readBuf, MAX_BUF_SIZE, fd);
+
+    if(fgets(readBuf, MAX_BUF_SIZE, fd) == NULL)
+    {
+        LogError("Failed to uninstalltion osp service\
+                        Inability of reading file.");
+        ThrowMsg(Exceptions::UninstallOspSvcFailed,
+                "Error occurs during\
+                uninstall osp service");
+    }
     LogDebug("return value : " << readBuf);
 
     int result = atoi(readBuf);

diff --git a/src/misc/widget_location.cpp b/src/misc/widget_location.cpp
index 4bd69f1..323a7d7 100644 (file)
--- a/src/misc/widget_location.cpp
+++ b/src/misc/widget_location.cpp
@@ -177,7 +177,7 @@ std::string WidgetLocation::getConfigurationDir() const
 {
     if (m_type == WrtDB::PKG_TYPE_HOSTED_WEB_APP) {
         std::string path = ".";
-        int index = m_widgetSource.find_last_of("\\/");
+        std::size_t index = m_widgetSource.find_last_of("\\/");
         if (index != std::string::npos) {
             path = m_widgetSource.substr(0, index);
         }

diff --git a/src/misc/widget_location.h b/src/misc/widget_location.h
index 60028bf..ca98aa6 100644 (file)
--- a/src/misc/widget_location.h
+++ b/src/misc/widget_location.h
@@ -203,10 +203,10 @@ class WidgetLocation
     void registerAppid(const std::string & appid);
 
   private:
+    std::string m_pkgid;                        //id of package
     std::string m_widgetSource;                   // Source widget zip
                                                   // file/widget url
     std::string m_appid;                        //id of app
-    std::string m_pkgid;                        //id of package
     std::string m_iconPath;                       //installed icon path
     WrtDB::PackagingType m_type;
     std::shared_ptr<DirectoryDeletor> m_temp;      //directory

diff --git a/src/pkg-manager/pkgmgr_signal_dummy.h b/src/pkg-manager/pkgmgr_signal_dummy.h
index 34f5837..4c1b3e4 100644 (file)
--- a/src/pkg-manager/pkgmgr_signal_dummy.h
+++ b/src/pkg-manager/pkgmgr_signal_dummy.h
@@ -33,12 +33,12 @@ class PkgmgrSignalDummy : public IPkgmgrSignal
 
     virtual ~PkgmgrSignalDummy()
     {}
-    bool setPkgname(const std::string& name)
+    bool setPkgname(const std::string& /*name*/)
     {
         return false;
     }
 
-    bool sendSignal(const std::string& key, const std::string& value) const
+    bool sendSignal(const std::string& /*key*/, const std::string& /*value*/) const
     {
         return false;
     }

diff --git a/src/wrt-installer/wrt_installer.cpp b/src/wrt-installer/wrt_installer.cpp
index 2a558a3..b9b016b 100644 (file)
--- a/src/wrt-installer/wrt_installer.cpp
+++ b/src/wrt-installer/wrt_installer.cpp
@@ -114,7 +114,7 @@ void WrtInstaller::OnCreate()
     fprintf(stderr,
             "===========================================================\n");
     fprintf(stderr, "# wrt-installer #\n");
-    fprintf(stderr, "# argc [%ld]\n", m_argc);
+    fprintf(stderr, "# argc [%d]\n", m_argc);
     fprintf(stderr, "# argv[0] = [%s]\n", m_argv[0]);
     fprintf(stderr, "# argv[1] = [%s]\n", m_argv[1]);
     fprintf(stderr, "# argv[2] = [%s]\n", m_argv[2]);