}
}
- virtual void Accept(const XmlAttribute& attribute)
+ virtual void Accept(const XmlAttribute& /*attribute*/)
{}
virtual void Accept(const Element& element)
return &IgnoringParser::Create;
}
- virtual void Accept(const Text& text)
+ virtual void Accept(const Text& /*text*/)
{
if (m_properNamespace) {
LogDebug("text");
}
}
- virtual void Accept(const Element& element)
+ virtual void Accept(const Element& /*element*/)
{}
virtual void Accept(const Text& /*text*/)
{
public:
virtual ActionFunc GetElementParser(const DPL::String& /*ns*/,
- const DPL::String& name)
+ const DPL::String& /*name*/)
{
return &IgnoringParser::Create;
}
return &IgnoringParser::Create;
}
- virtual void Accept(const XmlAttribute& attribute)
+ virtual void Accept(const XmlAttribute& /*attribute*/)
{}
virtual void Accept(const Element& element)
struct PdParser : public ElementParser
{
virtual ActionFunc GetElementParser(const DPL::String& /*ns*/,
- const DPL::String& name)
+ const DPL::String& /*name*/)
{
return &IgnoringParser::Create;
}
class CspParser : public ElementParser
{
public:
- virtual ActionFunc GetElementParser(const DPL::String& ns,
- const DPL::String& name)
+ virtual ActionFunc GetElementParser(const DPL::String& /*ns*/,
+ const DPL::String& /*name*/)
{
return &IgnoringParser::Create;
}
}
}
- virtual void Accept(const XmlAttribute& attribute)
+ virtual void Accept(const XmlAttribute& /*attribute*/)
{}
virtual void Accept(const Text& text)
void Job::SendFinishedFailure()
{}
-void Job::SendProgressIconPath(const std::string &path)
+void Job::SendProgressIconPath(const std::string &/*path*/)
{}
void Job::SaveExceptionData(const Jobs::JobExceptionBase&)
namespace WidgetInstall {
TaskCertify::TaskCertify(InstallerContext &inCont) :
DPL::TaskDecl<TaskCertify>(this),
- m_contextData(inCont),
- WidgetInstallPopup(inCont)
+ WidgetInstallPopup(inCont),
+ m_contextData(inCont)
{
AddStep(&TaskCertify::stepSignature);
LogDebug("Encrypt file: " << fileName);
std::string encFile = fileName + ".enc";
- struct stat info = {0};
+ struct stat info;
+ memset(&info, 0, sizeof(info));
if (stat(fileName.c_str(), &info) != 0)
{
int error = errno;
struct dirent* dEntry = NULL;
do {
struct stat statInfo;
- if (dEntry = readdir(dir)) {
+ if ((dEntry = readdir(dir)) != NULL) {
std::string fileName = dEntry->d_name;
std::string fullName = source + "/" + fileName;
"Error occurs during\
install osp service");
}
- fgets(readBuf, MAX_BUF_SIZE, fd);
+
+ if (fgets(readBuf, MAX_BUF_SIZE, fd) == NULL)
+ {
+ LogError("Failed to installtion osp service.\
+ Inability of reading file.");
+ ThrowMsg(Exceptions::InstallOspsvcFailed,
+ "Error occurs during\
+ install osp service");
+ }
LogDebug("return value : " << readBuf);
int result = atoi(readBuf);
std::string clientExeStr = GlobalConfig::GetWrtClientExec();
LogInfo("link -s " << clientExeStr << " " << exec);
- symlink(clientExeStr.c_str(), exec.c_str());
+ errno = 0;
+ if (symlink(clientExeStr.c_str(), exec.c_str()) != 0)
+ {
+ int error = errno;
+ if(error)
+ LogPedantic("Failed to make a symbolic name for a file "
+ << "[" << DPL::GetErrnoString(error) << "]");
+ ThrowMsg(Exceptions::InstallationFailed,
+ "Symbolic link creating is not done.");
+ }
m_context.job->UpdateProgress(
- InstallerContext::INSTALL_CREATE_EXECFILE,
- "Widget execfile creation Finished");
+ InstallerContext::INSTALL_CREATE_EXECFILE,
+ "Widget execfile creation Finished");
}
void TaskManifestFile::stepCopyIconFiles()
ail_appinfo_h ai = NULL;
ail_error_e ret;
- ret = ail_package_get_appinfo(appid, &ai);
+ ret = ail_get_appinfo(appid, &ai);
if (ai) {
- ail_package_destroy_appinfo(ai);
+ ail_destroy_appinfo(ai);
}
if (AIL_ERROR_NO_DATA == ret) {
"Widget SMACK Enabled");
#endif
}
+
} //namespace WidgetInstall
} //namespace Jobs
std::string clientPath = GlobalConfig::GetWrtClientExec();
LogInfo("link -s " << clientPath << " " << execFile);
- symlink(clientPath.c_str(), execFile.c_str());
+ errno = 0;
+ if( symlink(clientPath.c_str(), execFile.c_str()) != 0 )
+ {
+ int error = errno;
+ if(error)
+ LogPedantic("Failed to make a symbolic name for a file "
+ << "[" << DPL::GetErrnoString(error) << "]");
+ ThrowMsg(Exceptions::BackupFailed,
+ "Error occurs during rename file");
+ }
m_context.job->UpdateProgress(
InstallerContext::INSTALL_BACKUP_EXEC,
"Backup execution file for update");
void TaskDeleteCertificates::StepDeleteCertificates()
{
- pkgmgr_instcertinfo_h handle;
-
if ((pkgmgr_installer_delete_certinfo(
- const_cast<char*>((
- m_context.tzAppid).c_str()))) < 0)
+ const_cast<char*>((m_context.tzAppid).c_str()))) < 0)
{
LogError("pkgmgr_installer_delete_certinfo fail");
}
const char* package = m_context.tzAppid.c_str();
LogDebug("ail delete : " << package);
- ret = ail_package_get_appinfo(package, &ai);
+ ret = ail_get_appinfo(package, &ai);
if (ai) {
- ail_package_destroy_appinfo(ai);
+ ail_destroy_appinfo(ai);
}
if (AIL_ERROR_OK == ret) {
"Error occurs during\
uninstall osp service");
}
- fgets(readBuf, MAX_BUF_SIZE, fd);
+
+ if(fgets(readBuf, MAX_BUF_SIZE, fd) == NULL)
+ {
+ LogError("Failed to uninstalltion osp service\
+ Inability of reading file.");
+ ThrowMsg(Exceptions::UninstallOspSvcFailed,
+ "Error occurs during\
+ uninstall osp service");
+ }
LogDebug("return value : " << readBuf);
int result = atoi(readBuf);
{
if (m_type == WrtDB::PKG_TYPE_HOSTED_WEB_APP) {
std::string path = ".";
- int index = m_widgetSource.find_last_of("\\/");
+ std::size_t index = m_widgetSource.find_last_of("\\/");
if (index != std::string::npos) {
path = m_widgetSource.substr(0, index);
}
void registerAppid(const std::string & appid);
private:
+ std::string m_pkgid; //id of package
std::string m_widgetSource; // Source widget zip
// file/widget url
std::string m_appid; //id of app
- std::string m_pkgid; //id of package
std::string m_iconPath; //installed icon path
WrtDB::PackagingType m_type;
std::shared_ptr<DirectoryDeletor> m_temp; //directory
virtual ~PkgmgrSignalDummy()
{}
- bool setPkgname(const std::string& name)
+ bool setPkgname(const std::string& /*name*/)
{
return false;
}
- bool sendSignal(const std::string& key, const std::string& value) const
+ bool sendSignal(const std::string& /*key*/, const std::string& /*value*/) const
{
return false;
}
fprintf(stderr,
"===========================================================\n");
fprintf(stderr, "# wrt-installer #\n");
- fprintf(stderr, "# argc [%ld]\n", m_argc);
+ fprintf(stderr, "# argc [%d]\n", m_argc);
fprintf(stderr, "# argv[0] = [%s]\n", m_argv[0]);
fprintf(stderr, "# argv[1] = [%s]\n", m_argv[1]);
fprintf(stderr, "# argv[2] = [%s]\n", m_argv[2]);