reset: hisilicon: Use dev_err_probe instead of dev_err
authorWang Ming <machel@vivo.com>
Wed, 26 Jul 2023 11:45:45 +0000 (19:45 +0800)
committerPhilipp Zabel <p.zabel@pengutronix.de>
Fri, 28 Jul 2023 16:07:01 +0000 (18:07 +0200)
The probe process may generate EPROBE_DEFER. In this case,
dev_err_probe can still record err information.
This helps simplify code and standardize error output.

Signed-off-by: Wang Ming <machel@vivo.com>
Link: https://lore.kernel.org/r/20230726114555.5011-1-machel@vivo.com
Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
drivers/reset/hisilicon/reset-hi3660.c

index 087f28e..1beb275 100644 (file)
@@ -90,8 +90,8 @@ static int hi3660_reset_probe(struct platform_device *pdev)
                                                          "hisi,rst-syscon");
        }
        if (IS_ERR(rc->map)) {
-               dev_err(dev, "failed to get hisilicon,rst-syscon\n");
-               return PTR_ERR(rc->map);
+               return dev_err_probe(dev, PTR_ERR(rc->map),
+                       "failed to get hisilicon,rst-syscon\n");
        }
 
        rc->rst.ops = &hi3660_reset_ops,