ASoC: cs35l35: Fix an error handling path in 'cs35l35_i2c_probe()'
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Sun, 11 Apr 2021 12:51:06 +0000 (14:51 +0200)
committerMark Brown <broonie@kernel.org>
Tue, 13 Apr 2021 13:12:54 +0000 (14:12 +0100)
If 'devm_regmap_init_i2c()' fails, there is no need to goto err. We should
return directly as already done by the surrounding error handling paths.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Link: https://lore.kernel.org/r/15720439769ba94ffb65c90217392b0758b08f61.1618145369.git.christophe.jaillet@wanadoo.fr
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l35.c

index 55d529a..7b9f549 100644 (file)
@@ -1488,7 +1488,7 @@ static int cs35l35_i2c_probe(struct i2c_client *i2c_client,
        if (IS_ERR(cs35l35->regmap)) {
                ret = PTR_ERR(cs35l35->regmap);
                dev_err(dev, "regmap_init() failed: %d\n", ret);
-               goto err;
+               return ret;
        }
 
        for (i = 0; i < ARRAY_SIZE(cs35l35_supplies); i++)