mtd: maps: vmu-flash: Fix the (mtd core) switch to ref counters
authorMiquel Raynal <miquel.raynal@bootlin.com>
Tue, 5 Dec 2023 07:59:36 +0000 (08:59 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 1 Feb 2024 00:18:50 +0000 (16:18 -0800)
commit a7d84a2e7663bbe12394cc771107e04668ea313a upstream.

While switching to ref counters for track mtd devices use, the vmu-flash
driver was forgotten. The reason for reading the ref counter seems
debatable, but let's just fix the build for now.

Fixes: 19bfa9ebebb5 ("mtd: use refcount to prevent corruption")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202312022315.79twVRZw-lkp@intel.com/
Cc: stable@vger.kernel.org
Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20231205075936.13831-1-miquel.raynal@bootlin.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/mtd/maps/vmu-flash.c

index a7ec947..53019d3 100644 (file)
@@ -719,7 +719,7 @@ static int vmu_can_unload(struct maple_device *mdev)
        card = maple_get_drvdata(mdev);
        for (x = 0; x < card->partitions; x++) {
                mtd = &((card->mtd)[x]);
-               if (mtd->usecount > 0)
+               if (kref_read(&mtd->refcnt))
                        return 0;
        }
        return 1;