drm/amdgpu: don't require a job for cond_exec and shadow
authorAlex Deucher <alexander.deucher@amd.com>
Thu, 16 Mar 2023 15:33:43 +0000 (11:33 -0400)
committerAlex Deucher <alexander.deucher@amd.com>
Mon, 24 Apr 2023 22:16:27 +0000 (18:16 -0400)
We need to reset the shadow state every time we submit an
IB and there needs to be a COND_EXEC packet after the
SET_Q_PREEMPTION_MODE packet for it to work properly, so
we should emit both of these packets regardless of whether
there is a job present or not.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c

index aebc0e5..c955c3f 100644 (file)
@@ -223,11 +223,11 @@ int amdgpu_ib_schedule(struct amdgpu_ring *ring, unsigned num_ibs,
 
        amdgpu_ring_ib_begin(ring);
 
-       if (job && ring->funcs->emit_gfx_shadow)
+       if (ring->funcs->emit_gfx_shadow)
                amdgpu_ring_emit_gfx_shadow(ring, shadow_va, csa_va, gds_va,
                                            init_shadow, vmid);
 
-       if (job && ring->funcs->init_cond_exec)
+       if (ring->funcs->init_cond_exec)
                patch_offset = amdgpu_ring_init_cond_exec(ring);
 
        amdgpu_device_flush_hdp(adev, ring);