rtlwifi: move spin_lock_bh to spin_lock in tasklet
authorJeff Xie <chongguiguzi@gmail.com>
Tue, 19 Mar 2019 14:31:10 +0000 (22:31 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Thu, 4 Apr 2019 10:26:40 +0000 (13:26 +0300)
It is unnecessary to call spin_lock_bh in a tasklet.

Signed-off-by: Jeff Xie <chongguiguzi@gmail.com>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/realtek/rtlwifi/pci.c

index 48ca521..4055e0a 100644 (file)
@@ -499,16 +499,16 @@ static void _rtl_pci_tx_chk_waitq(struct ieee80211_hw *hw)
 
                        memset(&tcb_desc, 0, sizeof(struct rtl_tcb_desc));
 
-                       spin_lock_bh(&rtlpriv->locks.waitq_lock);
+                       spin_lock(&rtlpriv->locks.waitq_lock);
                        if (!skb_queue_empty(&mac->skb_waitq[tid]) &&
                            (ring->entries - skb_queue_len(&ring->queue) >
                             rtlhal->max_earlymode_num)) {
                                skb = skb_dequeue(&mac->skb_waitq[tid]);
                        } else {
-                               spin_unlock_bh(&rtlpriv->locks.waitq_lock);
+                               spin_unlock(&rtlpriv->locks.waitq_lock);
                                break;
                        }
-                       spin_unlock_bh(&rtlpriv->locks.waitq_lock);
+                       spin_unlock(&rtlpriv->locks.waitq_lock);
 
                        /* Some macaddr can't do early mode. like
                         * multicast/broadcast/no_qos data