Fix off-by one in urlOpen()

- the former implementation didn't take the ending '\0' into account

diff --git a/rpmio/rpmio.c b/rpmio/rpmio.c
index 4e4de81..39e0669 100644 (file)
--- a/rpmio/rpmio.c
+++ b/rpmio/rpmio.c
@@ -783,8 +783,7 @@ static FD_t urlOpen(const char * url, int flags, mode_t mode)
 
     dest = rpmGenPath(NULL, "%{_tmppath}/", "rpm-transfer.XXXXXX");
     close(mkstemp(dest));
-    cmd = xmalloc(strlen(urlhelper) + strlen(dest) + strlen(url) + 3);
-    sprintf(cmd, "%s %s %s\n", urlhelper, dest, url);
+    rasprintf(&cmd, "%s %s %s\n", urlhelper, dest, url);
     urlhelper = _free(urlhelper);
 
     if ((pid = fork()) == 0) {