perf probe: Handle strdup() failure
authorArnaldo Carvalho de Melo <acme@redhat.com>
Thu, 26 Feb 2015 14:47:18 +0000 (11:47 -0300)
committerArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 27 Feb 2015 13:08:29 +0000 (10:08 -0300)
We could end up returning 0 (Ok) with a NULL raw_path. Fix it.

Acked-by: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: David Ahern <dsahern@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Naohiro Aota <naota@elisp.net>
Link: http://lkml.kernel.org/n/tip-l0kcbcg5f4nnzqt01cv42vec@git.kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
tools/perf/util/probe-event.c

index 4a93bf4..9526cf3 100644 (file)
@@ -533,7 +533,7 @@ static int get_real_path(const char *raw_path, const char *comp_dir,
                else {
                        if (access(raw_path, R_OK) == 0) {
                                *new_path = strdup(raw_path);
-                               return 0;
+                               return *new_path ? 0 : -ENOMEM;
                        } else
                                return -errno;
                }