gpio: davinci: use {readl|writel}_relaxed() instead of __raw_*
authorLad, Prabhakar <prabhakar.csengg@gmail.com>
Wed, 11 Dec 2013 17:52:07 +0000 (23:22 +0530)
committerSekhar Nori <nsekhar@ti.com>
Wed, 25 Dec 2013 18:32:10 +0000 (00:02 +0530)
This patch replaces the __raw_readl/writel with
{readl|writel}_relaxed(), Altough the code runs on ARMv5
based SOCs, changing this will help using code for other
use cases (like with big-endian machines).

Signed-off-by: Lad, Prabhakar <prabhakar.csengg@gmail.com>
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
Signed-off-by: Sekhar Nori <nsekhar@ti.com>
drivers/gpio/gpio-davinci.c

index 84be701..805552c 100644 (file)
@@ -82,14 +82,14 @@ static inline int __davinci_direction(struct gpio_chip *chip,
        u32 mask = 1 << offset;
 
        spin_lock_irqsave(&d->lock, flags);
-       temp = __raw_readl(&g->dir);
+       temp = readl_relaxed(&g->dir);
        if (out) {
                temp &= ~mask;
-               __raw_writel(mask, value ? &g->set_data : &g->clr_data);
+               writel_relaxed(mask, value ? &g->set_data : &g->clr_data);
        } else {
                temp |= mask;
        }
-       __raw_writel(temp, &g->dir);
+       writel_relaxed(temp, &g->dir);
        spin_unlock_irqrestore(&d->lock, flags);
 
        return 0;
@@ -118,7 +118,7 @@ static int davinci_gpio_get(struct gpio_chip *chip, unsigned offset)
        struct davinci_gpio_controller *d = chip2controller(chip);
        struct davinci_gpio_regs __iomem *g = d->regs;
 
-       return (1 << offset) & __raw_readl(&g->in_data);
+       return (1 << offset) & readl_relaxed(&g->in_data);
 }
 
 /*
@@ -130,7 +130,7 @@ davinci_gpio_set(struct gpio_chip *chip, unsigned offset, int value)
        struct davinci_gpio_controller *d = chip2controller(chip);
        struct davinci_gpio_regs __iomem *g = d->regs;
 
-       __raw_writel((1 << offset), value ? &g->set_data : &g->clr_data);
+       writel_relaxed((1 << offset), value ? &g->set_data : &g->clr_data);
 }
 
 static int davinci_gpio_probe(struct platform_device *pdev)
@@ -227,8 +227,8 @@ static void gpio_irq_disable(struct irq_data *d)
        struct davinci_gpio_regs __iomem *g = irq2regs(d->irq);
        u32 mask = (u32) irq_data_get_irq_handler_data(d);
 
-       __raw_writel(mask, &g->clr_falling);
-       __raw_writel(mask, &g->clr_rising);
+       writel_relaxed(mask, &g->clr_falling);
+       writel_relaxed(mask, &g->clr_rising);
 }
 
 static void gpio_irq_enable(struct irq_data *d)
@@ -242,9 +242,9 @@ static void gpio_irq_enable(struct irq_data *d)
                status = IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING;
 
        if (status & IRQ_TYPE_EDGE_FALLING)
-               __raw_writel(mask, &g->set_falling);
+               writel_relaxed(mask, &g->set_falling);
        if (status & IRQ_TYPE_EDGE_RISING)
-               __raw_writel(mask, &g->set_rising);
+               writel_relaxed(mask, &g->set_rising);
 }
 
 static int gpio_irq_type(struct irq_data *d, unsigned trigger)
@@ -286,10 +286,10 @@ gpio_irq_handler(unsigned irq, struct irq_desc *desc)
                int             res;
 
                /* ack any irqs */
-               status = __raw_readl(&g->intstat) & mask;
+               status = readl_relaxed(&g->intstat) & mask;
                if (!status)
                        break;
-               __raw_writel(status, &g->intstat);
+               writel_relaxed(status, &g->intstat);
 
                /* now demux them to the right lowlevel handler */
                n = d->irq_base;
@@ -346,9 +346,9 @@ static int gpio_irq_type_unbanked(struct irq_data *data, unsigned trigger)
        if (trigger & ~(IRQ_TYPE_EDGE_FALLING | IRQ_TYPE_EDGE_RISING))
                return -EINVAL;
 
-       __raw_writel(mask, (trigger & IRQ_TYPE_EDGE_FALLING)
+       writel_relaxed(mask, (trigger & IRQ_TYPE_EDGE_FALLING)
                     ? &g->set_falling : &g->clr_falling);
-       __raw_writel(mask, (trigger & IRQ_TYPE_EDGE_RISING)
+       writel_relaxed(mask, (trigger & IRQ_TYPE_EDGE_RISING)
                     ? &g->set_rising : &g->clr_rising);
 
        return 0;
@@ -432,8 +432,8 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
 
                /* default trigger: both edges */
                g = gpio2regs(0);
-               __raw_writel(~0, &g->set_falling);
-               __raw_writel(~0, &g->set_rising);
+               writel_relaxed(~0, &g->set_falling);
+               writel_relaxed(~0, &g->set_rising);
 
                /* set the direct IRQs up to use that irqchip */
                for (gpio = 0; gpio < pdata->gpio_unbanked; gpio++, irq++) {
@@ -456,8 +456,8 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
 
                /* disabled by default, enabled only as needed */
                g = gpio2regs(gpio);
-               __raw_writel(~0, &g->clr_falling);
-               __raw_writel(~0, &g->clr_rising);
+               writel_relaxed(~0, &g->clr_falling);
+               writel_relaxed(~0, &g->clr_rising);
 
                /* set up all irqs in this bank */
                irq_set_chained_handler(bank_irq, gpio_irq_handler);
@@ -485,7 +485,7 @@ done:
         * BINTEN -- per-bank interrupt enable. genirq would also let these
         * bits be set/cleared dynamically.
         */
-       __raw_writel(binten, gpio_base + BINTEN);
+       writel_relaxed(binten, gpio_base + BINTEN);
 
        printk(KERN_INFO "DaVinci: %d gpio irqs\n", irq - gpio_to_irq(0));