Fix tests dying if an exception is thrown.

The test framework will generate an exception if any googletest assertion fails.
However, if there already is an ongoing exception, we do not want to throw
another one. Thus, we check if std::current_exception() is nullptr, and only
throw our own exception if it is nullptr.

diff --git a/tests/loader_testing_main.cpp b/tests/loader_testing_main.cpp
index 01b61bc72dc6e7a87d5a13bd4aac6ae742fc1325..6b5a44082e4c9dda0f8044a0f263063268aff8a0 100644 (file)
--- a/tests/loader_testing_main.cpp
+++ b/tests/loader_testing_main.cpp
@@ -31,6 +31,11 @@
 class ThrowListener : public testing::EmptyTestEventListener {
     void OnTestPartResult(const testing::TestPartResult& result) override {
         if (result.type() == testing::TestPartResult::kFatalFailure) {
+            // We need to make sure an exception wasn't already thrown so we dont throw another exception at the same time
+            std::exception_ptr ex = std::current_exception();
+            if (ex) {
+                return;
+            }
             throw testing::AssertionException(result);
         }
     }