mac80211: replace DEFINE_SIMPLE_ATTRIBUTE with DEFINE_DEBUGFS_ATTRIBUTE
authorYihao Han <hanyihao@vivo.com>
Fri, 18 Feb 2022 07:02:28 +0000 (23:02 -0800)
committerJohannes Berg <johannes.berg@intel.com>
Fri, 11 Mar 2022 10:42:36 +0000 (11:42 +0100)
Fix the following coccicheck warning:
./drivers/net/wireless/mac80211_hwsim.c:1040:0-23: WARNING:
hwsim_fops_rx_rssi should be defined with
DEFINE_DEBUGFS_ATTRIBUTE

Signed-off-by: Yihao Han <hanyihao@vivo.com>
Link: https://lore.kernel.org/r/20220218070228.6210-1-hanyihao@vivo.com
[fix indentation]
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
drivers/net/wireless/mac80211_hwsim.c

index b23c6deaa4862af40c8e4efcd142631de19fd86c..10b08212d1ff01ea78e2ff5b650bf311b7658c6f 100644 (file)
@@ -1037,9 +1037,9 @@ static int hwsim_fops_rx_rssi_write(void *dat, u64 val)
        return 0;
 }
 
-DEFINE_SIMPLE_ATTRIBUTE(hwsim_fops_rx_rssi,
-                       hwsim_fops_rx_rssi_read, hwsim_fops_rx_rssi_write,
-                       "%lld\n");
+DEFINE_DEBUGFS_ATTRIBUTE(hwsim_fops_rx_rssi,
+                        hwsim_fops_rx_rssi_read, hwsim_fops_rx_rssi_write,
+                        "%lld\n");
 
 static netdev_tx_t hwsim_mon_xmit(struct sk_buff *skb,
                                        struct net_device *dev)