NFS: clean up a needless assignment in nfs_file_write()
authorLukas Bulwahn <lukas.bulwahn@gmail.com>
Wed, 10 Aug 2022 11:40:01 +0000 (13:40 +0200)
committerAnna Schumaker <Anna.Schumaker@Netapp.com>
Mon, 3 Oct 2022 15:26:36 +0000 (11:26 -0400)
Commit 064109db53ec ("NFS: remove redundant code in nfs_file_write()")
identifies that filemap_fdatawait_range() will always return 0 and removes
a dead error-handling case in nfs_file_write(). With this change however,
assigning the return of filemap_fdatawait_range() to the result variable is
a dead store.

Remove this needless assignment.

No functional change. No change in object code.

Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
fs/nfs/file.c

index e032fe2..7a4d2fe 100644 (file)
@@ -655,9 +655,9 @@ ssize_t nfs_file_write(struct kiocb *iocb, struct iov_iter *from)
                        goto out;
        }
        if (mntflags & NFS_MOUNT_WRITE_WAIT) {
-               result = filemap_fdatawait_range(file->f_mapping,
-                                                iocb->ki_pos - written,
-                                                iocb->ki_pos - 1);
+               filemap_fdatawait_range(file->f_mapping,
+                                       iocb->ki_pos - written,
+                                       iocb->ki_pos - 1);
        }
        result = generic_write_sync(iocb, written);
        if (result < 0)