fix svace issue (TOCTTOU_SEQUENCE)

Change-Id: I06b8d3775c85da8f3e4eaddcee95ad796d2d7f6d
Signed-off-by: HyiHong Chae <hh.chae@samsung.com>

diff --git a/packaging/mtp-initiator.spec b/packaging/mtp-initiator.spec
index 0c72633e2b5e22566f60d17138a4b24ba469a4f3..5ec678416141588450348bf21494580c11698806 100755 (executable)
--- a/packaging/mtp-initiator.spec
+++ b/packaging/mtp-initiator.spec
@@ -1,6 +1,6 @@
 Name:       mtp-initiator
 Summary:    mtp(media transfer protocol) initiator
-Version:    1.4.6
+Version:    1.4.7
 Release:    1
 Group:      Network & Connectivity/Other
 License:    Apache-2.0

diff --git a/src/daemon/mtp_daemon_gdbus_manager.c b/src/daemon/mtp_daemon_gdbus_manager.c
index f1e5dab54af2849a172f8efaad0d9ab0df5a4520..d92e92cce723969a2b3c92fd3540a6abf580746a 100755 (executable)
--- a/src/daemon/mtp_daemon_gdbus_manager.c
+++ b/src/daemon/mtp_daemon_gdbus_manager.c
@@ -301,14 +301,10 @@ static void __manager_get_object_thread_func(gpointer user_data)
                device = (LIBMTP_mtpdevice_t *)device_info->device;
                MTP_LOGI("device_id: %d, device: %p, dest_path: %s", device_id, device, dest_path);
 
-               /* file open */
-               if (access(dest_path, F_OK) >= 0) {
-                       MTP_LOGE("file exist - dest_path: %s", dest_path);
-
-                       if (unlink(dest_path) < 0)
-                               MTP_LOGE("remove fail - dest_path: %s", dest_path);
-               }
+               /* file remove */
+               unlink(dest_path);
 
+               /* file open */
                fd = open(dest_path, O_WRONLY | O_CREAT | O_EXCL, 0644);
 
                if (fd < 0) {
@@ -375,14 +371,10 @@ static void __manager_get_thumbnail_thread_func(gpointer user_data)
                device = (LIBMTP_mtpdevice_t *)device_info->device;
                MTP_LOGI("device_id: %d, device: %p, dest_path: %s", device_id, device, dest_path);
 
-               /* file open */
-               if (access(dest_path, F_OK) >= 0) {
-                       MTP_LOGE("file exist - dest_path: %s", dest_path);
-
-                       if (unlink(dest_path) < 0)
-                               MTP_LOGE("remove fail - dest_path: %s", dest_path);
-               }
+               /* file remove */
+               unlink(dest_path);
 
+               /* file open */
                fd = open(dest_path, O_WRONLY | O_CREAT | O_EXCL, 0644);
 
                if (fd < 0) {