projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
9030a9e
)
drm/sun4i: dsi: delete unnecessary IS_ERR() checks
author
Dan Carpenter
<dan.carpenter@oracle.com>
Thu, 28 Apr 2022 12:26:23 +0000
(15:26 +0300)
committer
Maxime Ripard
<maxime@cerno.tech>
Fri, 29 Apr 2022 14:26:49 +0000
(16:26 +0200)
The "dsi->bus_clk" pointer cannot be an error pointer at this point.
The check is confusing and unnecessary. Delete it.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link:
https://patchwork.freedesktop.org/patch/msgid/YmqH71MtoGn2AXUg@kili
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
patch
|
blob
|
history
diff --git
a/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
b/drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
index
527c7b2
..
b4dfa16
100644
(file)
--- a/
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
+++ b/
drivers/gpu/drm/sun4i/sun6i_mipi_dsi.c
@@
-1193,8
+1193,8
@@
err_remove_dsi_host:
err_unprotect_clk:
clk_rate_exclusive_put(dsi->mod_clk);
err_attach_clk:
- if (!IS_ERR(dsi->bus_clk))
- regmap_mmio_detach_clk(dsi->regs);
+ regmap_mmio_detach_clk(dsi->regs);
+
return ret;
}
@@
-1207,8
+1207,7
@@
static int sun6i_dsi_remove(struct platform_device *pdev)
mipi_dsi_host_unregister(&dsi->host);
clk_rate_exclusive_put(dsi->mod_clk);
- if (!IS_ERR(dsi->bus_clk))
- regmap_mmio_detach_clk(dsi->regs);
+ regmap_mmio_detach_clk(dsi->regs);
return 0;
}