hwmon: (oxp-sensors) Simplify logic of error return
authorJoaquín Ignacio Aramendía <samsagax@gmail.com>
Sat, 17 Jun 2023 18:11:43 +0000 (15:11 -0300)
committerGuenter Roeck <linux@roeck-us.net>
Sun, 18 Jun 2023 15:54:31 +0000 (08:54 -0700)
Take return logic on error out of if-else, eliminating
duplicated code in tt_togle_store() function.

Signed-off-by: Joaquín Ignacio Aramendía <samsagax@gmail.com>
Link: https://lore.kernel.org/r/20230617181159.32844-3-samsagax@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/oxp-sensors.c

index 584e48d..1e59d97 100644 (file)
@@ -226,13 +226,12 @@ static ssize_t tt_toggle_store(struct device *dev,
 
        if (value) {
                rval = tt_toggle_enable();
-               if (rval)
-                       return rval;
        } else {
                rval = tt_toggle_disable();
-               if (rval)
-                       return rval;
        }
+       if (rval)
+               return rval;
+
        return count;
 }