curl_multi_cleanup: ignore SIGPIPE better
authorJeff King <peff@peff.net>
Mon, 5 May 2014 10:47:46 +0000 (12:47 +0200)
committerDaniel Stenberg <daniel@haxx.se>
Mon, 5 May 2014 10:47:46 +0000 (12:47 +0200)
When looping and closing each individual connection left open, the
SIGPIPE ignoring was not done and could thus lead to death by signal 13.

Bug: http://thread.gmane.org/gmane.comp.version-control.git/238242

lib/multi.c

index 7720c95..c52db96 100644 (file)
@@ -1806,10 +1806,13 @@ static void close_all_connections(struct Curl_multi *multi)
 
   conn = Curl_conncache_find_first_connection(multi->conn_cache);
   while(conn) {
+    SIGPIPE_VARIABLE(pipe_st);
     conn->data = multi->closure_handle;
 
+    sigpipe_ignore(conn->data, &pipe_st);
     /* This will remove the connection from the cache */
     (void)Curl_disconnect(conn, FALSE);
+    sigpipe_restore(&pipe_st);
 
     conn = Curl_conncache_find_first_connection(multi->conn_cache);
   }