ACPI: battery: Accept charges over the design capacity as full
authorAndré Almeida <andrealmeid@collabora.com>
Fri, 8 Oct 2021 03:05:29 +0000 (00:05 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 18 Nov 2021 18:16:15 +0000 (19:16 +0100)
[ Upstream commit 2835f327bd1240508db2c89fe94a056faa53c49a ]

Some buggy firmware and/or brand new batteries can support a charge that's
slightly over the reported design capacity. In such cases, the kernel will
report to userspace that the charging state of the battery is "Unknown",
when in reality the battery charge is "Full", at least from the design
capacity point of view. Make the fallback condition accepts capacities
over the designed capacity so userspace knows that is full.

Signed-off-by: André Almeida <andrealmeid@collabora.com>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/acpi/battery.c

index dae91f9..8afa85d 100644 (file)
@@ -169,7 +169,7 @@ static int acpi_battery_is_charged(struct acpi_battery *battery)
                return 1;
 
        /* fallback to using design values for broken batteries */
-       if (battery->design_capacity == battery->capacity_now)
+       if (battery->design_capacity <= battery->capacity_now)
                return 1;
 
        /* we don't do any sort of metric based on percentages */