Bluetooth: Remove unnecessary use of hci_dev_list_lock
authorJohan Hedberg <johan.hedberg@intel.com>
Fri, 20 May 2011 18:50:41 +0000 (11:50 -0700)
committerGustavo F. Padovan <padovan@profusion.mobi>
Wed, 8 Jun 2011 19:58:16 +0000 (16:58 -0300)
The get_connections function has no need to use hci_dev_list_lock. The
code was there probably because of a copy-paste mistake.

Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>
net/bluetooth/mgmt.c

index dae382c..fe835b8 100644 (file)
@@ -1092,8 +1092,6 @@ static int get_connections(struct sock *sk, u16 index)
 
        put_unaligned_le16(count, &rp->conn_count);
 
-       read_lock(&hci_dev_list_lock);
-
        i = 0;
        list_for_each(p, &hdev->conn_hash.list) {
                struct hci_conn *c = list_entry(p, struct hci_conn, list);
@@ -1101,8 +1099,6 @@ static int get_connections(struct sock *sk, u16 index)
                bacpy(&rp->conn[i++], &c->dst);
        }
 
-       read_unlock(&hci_dev_list_lock);
-
        err = cmd_complete(sk, index, MGMT_OP_GET_CONNECTIONS, rp, rp_len);
 
 unlock: