mpdparser: Modify return of the function for loading external resources to void
authorSeungha Yang <sh.yang@lge.com>
Sun, 20 Nov 2016 06:10:42 +0000 (15:10 +0900)
committerSebastian Dröge <sebastian@centricular.com>
Mon, 21 Nov 2016 07:43:30 +0000 (09:43 +0200)
gst_mpd_client_fetch_on_load_external_resources() never ever return
FALSE due to modified external xml loading functions.

https://bugzilla.gnome.org/show_bug.cgi?id=774463

ext/dash/gstmpdparser.c

index 4bccb961a86802a81f64d76b3f41e6cca08262ef..8c32402367b8310956e5742351efdf93f531ed40 100644 (file)
@@ -3628,7 +3628,7 @@ gst_mpd_client_check_profiles (GstMpdClient * client)
   }
 }
 
-static gboolean
+static void
 gst_mpd_client_fetch_on_load_external_resources (GstMpdClient * client)
 {
   GList *l;
@@ -3761,12 +3761,6 @@ gst_mpd_client_fetch_on_load_external_resources (GstMpdClient * client)
 
     l = l->next;
   }
-
-  return TRUE;
-
-syntax_error:
-
-  return FALSE;
 }
 
 gboolean
@@ -3812,9 +3806,7 @@ gst_mpd_parse (GstMpdClient * client, const gchar * data, gint size)
 
     if (ret) {
       gst_mpd_client_check_profiles (client);
-
-      if (!gst_mpd_client_fetch_on_load_external_resources (client))
-        return FALSE;
+      gst_mpd_client_fetch_on_load_external_resources (client);
     }
   }