soc: bcm: brcmstb: pm: pm-arm: Fix refcount leak in brcmstb_pm_probe
authorMiaoqian Lin <linmq006@gmail.com>
Thu, 26 May 2022 07:53:22 +0000 (11:53 +0400)
committerFlorian Fainelli <f.fainelli@gmail.com>
Wed, 8 Jun 2022 09:21:17 +0000 (02:21 -0700)
of_find_matching_node() returns a node pointer with refcount
incremented, we should use of_node_put() on it when not need anymore.
Add missing of_node_put() to avoid refcount leak.

In brcmstb_init_sram, it pass dn to of_address_to_resource(),
of_address_to_resource() will call of_find_device_by_node() to take
reference, so we should release the reference returned by
of_find_matching_node().

Fixes: 0b741b8234c8 ("soc: bcm: brcmstb: Add support for S2/S3/S5 suspend states (ARM)")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
drivers/soc/bcm/brcmstb/pm/pm-arm.c

index 3cbb165d6e30900c224058508cd3df7702d029a6..70ad0f3dce283a828117ffcaeccd08d416aebe48 100644 (file)
@@ -783,6 +783,7 @@ static int brcmstb_pm_probe(struct platform_device *pdev)
        }
 
        ret = brcmstb_init_sram(dn);
+       of_node_put(dn);
        if (ret) {
                pr_err("error setting up SRAM for PM\n");
                return ret;