fs/ntfs3: Fix missing i_op in ntfs_read_mft
authorKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Thu, 26 May 2022 09:51:03 +0000 (12:51 +0300)
committerKonstantin Komarov <almaz.alexandrovich@paragon-software.com>
Mon, 6 Jun 2022 15:38:58 +0000 (18:38 +0300)
There is null pointer dereference because i_op == NULL.
The bug happens because we don't initialize i_op for records in $Extend.
Fixes: 82cae269cfa9 ("fs/ntfs3: Add initialization of super block")

Reported-by: Liangbin Lian <jjm2473@gmail.com>
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
fs/ntfs3/inode.c

index 3804526..6c78930 100644 (file)
@@ -430,6 +430,7 @@ end_enum:
        } else if (fname && fname->home.low == cpu_to_le32(MFT_REC_EXTEND) &&
                   fname->home.seq == cpu_to_le16(MFT_REC_EXTEND)) {
                /* Records in $Extend are not a files or general directories. */
+               inode->i_op = &ntfs_file_inode_operations;
        } else {
                err = -EINVAL;
                goto out;