Fix static analysis issue

Avoid sign extension
Use of auto that causes a copy

Change-Id: Ieaa6d37d8cdc0f7c8e9d2f793b32372c0cf2934e
Signed-off-by: Ilho Kim <ilho159.kim@samsung.com>

diff --git a/src/lib/wgt_archive_info.cc b/src/lib/wgt_archive_info.cc
index edc7d77..0fd5307 100644 (file)
--- a/src/lib/wgt_archive_info.cc
+++ b/src/lib/wgt_archive_info.cc
@@ -140,7 +140,7 @@ bool WgtArchiveInfo::ReadIcon(const bf::path& icon, const bf::path& tmp_dir) {
 
   icon_buf_.resize(len / sizeof(unsigned char));
   ifs.read(reinterpret_cast<char*>(icon_buf_.data()), len);
-  if (len != icon_buf_.size()) {
+  if (static_cast<size_t>(len) != icon_buf_.size()) {
     LOG(ERROR) << "Reading icon failed, icon size is: " << len
                << ", but read size is: " << icon_buf_.size();
     return false;

diff --git a/src/wgt/step/pkgmgr/step_generate_xml.cc b/src/wgt/step/pkgmgr/step_generate_xml.cc
index 7294e17..abae81c 100644 (file)
--- a/src/wgt/step/pkgmgr/step_generate_xml.cc
+++ b/src/wgt/step/pkgmgr/step_generate_xml.cc
@@ -595,8 +595,8 @@ void StepGenerateXml::GenerateAccount(xmlTextWriterPtr writer) {
 }
 
 void StepGenerateXml::GenerateIme(xmlTextWriterPtr writer) {
-  const auto &ime = context_->manifest_plugins_data.get().ime_info.get();
-  const auto ime_uuid = ime.uuid();
+  const auto& ime = context_->manifest_plugins_data.get().ime_info.get();
+  const auto& ime_uuid = ime.uuid();
   if (!ime_uuid.empty()) {
     xmlTextWriterStartElement(writer, BAD_CAST "ime");