i2c: tegra: replace spin_lock_irqsave with spin_lock in ISR
authorjun qian <hangdianqj@163.com>
Tue, 11 Sep 2018 14:54:46 +0000 (07:54 -0700)
committerWolfram Sang <wsa@the-dreams.de>
Tue, 11 Dec 2018 19:56:52 +0000 (20:56 +0100)
As you are already in ISR, it is unnecessary to call spin_lock_irqsave.

Signed-off-by: jun qian <hangdianqj@163.com>
Reviewed-by: Dmitry Osipenko <digetx@gmail.com>
Acked-by: Thierry Reding <treding@nvidia.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-tegra.c

index 437294e..64b348a 100644 (file)
@@ -608,11 +608,10 @@ static irqreturn_t tegra_i2c_isr(int irq, void *dev_id)
        u32 status;
        const u32 status_err = I2C_INT_NO_ACK | I2C_INT_ARBITRATION_LOST;
        struct tegra_i2c_dev *i2c_dev = dev_id;
-       unsigned long flags;
 
        status = i2c_readl(i2c_dev, I2C_INT_STATUS);
 
-       spin_lock_irqsave(&i2c_dev->xfer_lock, flags);
+       spin_lock(&i2c_dev->xfer_lock);
        if (status == 0) {
                dev_warn(i2c_dev->dev, "irq status 0 %08x %08x %08x\n",
                         i2c_readl(i2c_dev, I2C_PACKET_TRANSFER_STATUS),
@@ -670,7 +669,7 @@ err:
 
        complete(&i2c_dev->msg_complete);
 done:
-       spin_unlock_irqrestore(&i2c_dev->xfer_lock, flags);
+       spin_unlock(&i2c_dev->xfer_lock);
        return IRQ_HANDLED;
 }