[Shell] Fail when trying to add a duplicated route (#6613)

diff --git a/Xamarin.Forms.Core.UnitTests/ShellTests.cs b/Xamarin.Forms.Core.UnitTests/ShellTests.cs
index c4506fa..23ecae8 100644 (file)
--- a/Xamarin.Forms.Core.UnitTests/ShellTests.cs
+++ b/Xamarin.Forms.Core.UnitTests/ShellTests.cs
@@ -129,6 +129,14 @@ namespace Xamarin.Forms.Core.UnitTests
                        Assert.Catch(typeof(ArgumentException), () => Routing.RegisterRoute("app://tab2/IMPL_tab21", typeof(ShellItem)));
                }
 
+               [Test]
+               public async Task FailWhenAddingDuplicatedRouting()
+               {
+                       var route = "dogs";
+                       Routing.RegisterRoute(route, typeof(ShellItem));
+
+                       Assert.Catch(typeof(ArgumentException), () => Routing.RegisterRoute("dogs", typeof(ShellItem)));
+               }
 
                [Test]
                public async Task RelativeGoTo()

diff --git a/Xamarin.Forms.Core/Routing.cs b/Xamarin.Forms.Core/Routing.cs
index 8ab67f4..8feecbf 100644 (file)
--- a/Xamarin.Forms.Core/Routing.cs
+++ b/Xamarin.Forms.Core/Routing.cs
@@ -153,6 +153,9 @@ namespace Xamarin.Forms
                                if (IsImplicit(part))
                                        throw new ArgumentException($"Route contains invalid characters in \"{part}\"");
                        }
+
+                       if (CompareWithRegisteredRoutes(route))
+                               throw new ArgumentException($"Duplicated Route: \"{route}\"");
                }
 
                class TypeRouteFactory : RouteFactory