edje_recc: don't use negative exit code in a /bin/sh script
authorDerek Foreman <derekf@osg.samsung.com>
Fri, 3 Nov 2017 20:46:11 +0000 (15:46 -0500)
committerDerek Foreman <derekf@osg.samsung.com>
Fri, 3 Nov 2017 20:46:11 +0000 (15:46 -0500)
Apparently this isn't well supported by dash, which will print an
error and return a 2, where zsh and bash will return 255.

Explicitly returning 255 seems least surprising.

see https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=772322

 #IHaveNoIdeaWhatThisScriptDoes

src/bin/edje/edje_recc

index 2ae81ad..837fa62 100644 (file)
@@ -14,7 +14,7 @@ usage () {
   echo "-no-raw                  Do NOT allow images to be zero compression"
   echo "-min-quality VAL         Do NOT allow lossy images with quality < VAL (0-100)"
   echo "-max-quality VAL         Do NOT allow lossy images with quality > VAL (0-100)"
-  exit -1
+  exit 255
 }
 
 if [ $# -lt 1 ]; then