dmaengine: Use of_property_present() for testing DT property presence
authorRob Herring <robh@kernel.org>
Fri, 10 Mar 2023 14:47:03 +0000 (08:47 -0600)
committerVinod Koul <vkoul@kernel.org>
Fri, 17 Mar 2023 17:41:42 +0000 (23:11 +0530)
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230310144704.1541976-1-robh@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/of-dma.c

index ac61ecd..775a7f4 100644 (file)
@@ -264,7 +264,7 @@ struct dma_chan *of_dma_request_slave_channel(struct device_node *np,
        }
 
        /* Silently fail if there is not even the "dmas" property */
-       if (!of_find_property(np, "dmas", NULL))
+       if (!of_property_present(np, "dmas"))
                return ERR_PTR(-ENODEV);
 
        count = of_property_count_strings(np, "dma-names");