projects
/
platform
/
kernel
/
linux-rpi.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
fbf6f48
)
net: ethernet: ti: am65-cpsw: Call of_node_put() on error path
author
Dan Carpenter
<dan.carpenter@linaro.org>
Mon, 12 Jun 2023 07:18:50 +0000
(10:18 +0300)
committer
Jakub Kicinski
<kuba@kernel.org>
Wed, 14 Jun 2023 03:47:03 +0000
(20:47 -0700)
This code returns directly but it should instead call of_node_put()
to drop some reference counts.
Fixes:
dab2b265dd23
("net: ethernet: ti: am65-cpsw: Add support for SERDES configuration")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Link:
https://lore.kernel.org/r/e3012f0c-1621-40e6-bf7d-03c276f6e07f@kili.mountain
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/ti/am65-cpsw-nuss.c
patch
|
blob
|
history
diff --git
a/drivers/net/ethernet/ti/am65-cpsw-nuss.c
b/drivers/net/ethernet/ti/am65-cpsw-nuss.c
index
11cbcd9
..
bebcfd5
100644
(file)
--- a/
drivers/net/ethernet/ti/am65-cpsw-nuss.c
+++ b/
drivers/net/ethernet/ti/am65-cpsw-nuss.c
@@
-2068,7
+2068,7
@@
static int am65_cpsw_nuss_init_slave_ports(struct am65_cpsw_common *common)
/* Initialize the Serdes PHY for the port */
ret = am65_cpsw_init_serdes_phy(dev, port_np, port);
if (ret)
-
return re
t;
+
goto of_node_pu
t;
port->slave.mac_only =
of_property_read_bool(port_np, "ti,mac-only");