xfs: don't log every time we clear the log incompat flags
authorDarrick J. Wong <djwong@kernel.org>
Fri, 27 May 2022 00:29:51 +0000 (10:29 +1000)
committerDave Chinner <david@fromorbit.com>
Fri, 27 May 2022 00:29:51 +0000 (10:29 +1000)
There's no need to spam the logs every time we clear the log incompat
flags -- if someone is periodically using one of these features, they'll
be cleared every time the log tries to clean itself, which can get
pretty chatty:

$ dmesg | grep -i clear
[ 5363.894711] XFS (sdd): Clearing log incompat feature flags.
[ 5365.157516] XFS (sdd): Clearing log incompat feature flags.
[ 5369.388543] XFS (sdd): Clearing log incompat feature flags.
[ 5371.281246] XFS (sdd): Clearing log incompat feature flags.

These aren't high value messages either -- nothing's gone wrong, and
nobody's trying anything tricky.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Dave Chinner <david@fromorbit.com>
fs/xfs/xfs_mount.c

index 0c0bcbd..daa8d29 100644 (file)
@@ -1356,7 +1356,6 @@ xfs_clear_incompat_log_features(
 
        if (xfs_sb_has_incompat_log_feature(&mp->m_sb,
                                XFS_SB_FEAT_INCOMPAT_LOG_ALL)) {
-               xfs_info(mp, "Clearing log incompat feature flags.");
                xfs_sb_remove_incompat_log_features(&mp->m_sb);
                ret = true;
        }