ASoC: fsl_xcvr: fix potential resource leak
authorViorel Suman <viorel.suman@nxp.com>
Tue, 24 Nov 2020 14:19:57 +0000 (16:19 +0200)
committerMark Brown <broonie@kernel.org>
Wed, 25 Nov 2020 12:54:43 +0000 (12:54 +0000)
"fw" variable must be relased before return.

Signed-off-by: Viorel Suman <viorel.suman@nxp.com>
Link: https://lore.kernel.org/r/20201124141957.20481-1-viorel.suman@oss.nxp.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/fsl/fsl_xcvr.c

index 2a28810..3d58c88 100644 (file)
@@ -706,6 +706,7 @@ static int fsl_xcvr_load_firmware(struct fsl_xcvr *xcvr)
        /* RAM is 20KiB = 16KiB code + 4KiB data => max 10 pages 2KiB each */
        if (rem > 16384) {
                dev_err(dev, "FW size %d is bigger than 16KiB.\n", rem);
+               release_firmware(fw);
                return -ENOMEM;
        }