Test: tst_QFile::writeLargeDataBlock() unstable failure as XFAIL
authorCaroline Chao <caroline.chao@digia.com>
Wed, 26 Sep 2012 06:02:49 +0000 (08:02 +0200)
committerThe Qt Project <gerrit-noreply@qt-project.org>
Wed, 26 Sep 2012 08:08:59 +0000 (10:08 +0200)
While the large data block can be written to a file, the test is
also showing instability while reading back the written block.

Adding another expected failure to address this instability.

Task-number: QTBUG-26906

Change-Id: I9704d441cf2bd6d7ef0f9023240ea61bb89561b6
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
tests/auto/corelib/io/qfile/tst_qfile.cpp

index 0478b07..d0fa303 100644 (file)
@@ -2277,7 +2277,7 @@ void tst_QFile::writeLargeDataBlock()
             qWarning() << qPrintable(QString("Error writing a large data block to [%1]: %2")
                 .arg(fileName)
                 .arg(file.errorString()));
-            QEXPECT_FAIL("unc file", "QTBUG-26906", Abort);
+            QEXPECT_FAIL("unc file", "QTBUG-26906 writing", Abort);
         }
 #endif
         QCOMPARE( fileWriteOriginalData, originalDataSize );
@@ -2294,9 +2294,17 @@ void tst_QFile::writeLargeDataBlock()
         QVERIFY2( openFile(file, QIODevice::ReadOnly, (FileType)type),
             qPrintable(QString("Couldn't open file for reading: [%1]").arg(fileName)) );
         readData = file.readAll();
+
+#if defined(Q_OS_WIN)
+        if (readData != originalData) {
+            qWarning() << qPrintable(QString("Error reading a large data block from [%1]: %2")
+                .arg(fileName)
+                .arg(file.errorString()));
+            QEXPECT_FAIL("unc file", "QTBUG-26906 reading", Abort);
+        }
+#endif
         closeFile(file);
     }
-
     QCOMPARE( readData, originalData );
     QVERIFY( QFile::remove(fileName) );
 }