Find on page does not hide on fullscreen 49/91549/2
authorKamil Nowac <k.nowac@samsung.com>
Mon, 10 Oct 2016 06:53:11 +0000 (08:53 +0200)
committerKamil Nowac <k.nowac@samsung.com>
Tue, 11 Oct 2016 08:56:39 +0000 (10:56 +0200)
[Issue]    http://suprem.sec.samsung.net/jira/browse/TWF-2257
[Problem]  As in the title
[Solution] Added signal
[Verify]   - Open youtube.com. open find on page. go to fullscreen
           in portrait mode. rotate while in fullscreen to
           landscape mode.
           find on page should not be visible.
           - turn off fullscreen mode
           find on page should be visible

Change-Id: Ic6a3295ac11811fc6f2e45e5a4b30c2c51e6eb4d

services/SimpleUI/SimpleUI.cpp
services/WebPageUI/WebPageUI.cpp
services/WebPageUI/WebPageUI.h

index 13567e69b1e58464611e297912441430f54ea7d9..7a6a22270e99f7fa8f22dd18f94efc2ec7bf4d33 100755 (executable)
@@ -385,6 +385,7 @@ void SimpleUI::connectWebPageSignals()
     m_webPageUI->deleteBookmark.connect(boost::bind(&SimpleUI::deleteBookmark, this));
     m_webPageUI->showBookmarkFlowUI.connect(boost::bind(&SimpleUI::showBookmarkFlowUI, this));
     m_webPageUI->showFindOnPageUI.connect(boost::bind(&SimpleUI::showFindOnPageUI, this, std::string()));
+    m_webPageUI->isFindOnPageVisible.connect(boost::bind(&FindOnPageUI::isVisible, m_findOnPageUI.get()));
     m_webPageUI->showSettingsUI.connect(boost::bind(&SettingsManager::showSettingsBaseUI, m_settingsManager.get()));
     m_webPageUI->addNewTab.connect(boost::bind(&SimpleUI::newTabClicked, this));
     m_webPageUI->getURIEntry().mobileEntryFocused.connect(boost::bind(&WebPageUI::mobileEntryFocused, m_webPageUI));
index 40bcb40e9b5241a9113412a247de9904df886ad9..44a473ac33c1adcf8bb04a7706035155ee96c136 100755 (executable)
@@ -329,13 +329,18 @@ void WebPageUI::fullscreenModeSet(bool state)
 {
     BROWSER_LOGD("[%s:%d] ", __PRETTY_FUNCTION__, __LINE__);
     auto landscape = isLandscape();
+    auto findonpage = isFindOnPageVisible();
     m_fullscreen = state;
-    if (!state)
+    if (!state) {
         elm_object_signal_emit(m_mainLayout, "show_uri_bar", "ui");
-    else if (landscape && state) {
+        if (findonpage && *findonpage)
+            elm_object_signal_emit(m_mainLayout, "show_findonpage", "ui");
+    } else if (landscape && state) {
         (*landscape) ?
             elm_object_signal_emit(m_mainLayout, "hide_uri_bar_landscape", "ui") :
             elm_object_signal_emit(m_mainLayout, "hide_uri_bar_vertical", "ui");
+        if (findonpage && *findonpage)
+            hideFindOnPage();
     }
     showBottomBar(!state);
 }
index 034260eb925bcf87f9f543c7c8b9f19e0e9a3910..f318b17563fa559742f80de2b80a43c18e6f7755 100755 (executable)
@@ -158,6 +158,7 @@ public:
     boost::signals2::signal<void ()> deleteMostVisited;
     boost::signals2::signal<void ()> addToQuickAccess;
     boost::signals2::signal<bool ()> isMostVisited;
+    boost::signals2::signal<bool ()> isFindOnPageVisible;
 
     boost::signals2::signal<std::string ()> requestCurrentPageForWebPageUI;
     boost::signals2::signal<basic_webengine::State ()> getEngineState;