Fix writable attribute of RegExp properties

Most of the properties are in fact not writable.

Change-Id: I21a8c97fb98ef3c583b284093ec9be52b72b1544
Reviewed-by: Lars Knoll <lars.knoll@digia.com>

diff --git a/qmljs_objects.cpp b/qmljs_objects.cpp
index c57355d..cf24c00 100644 (file)
--- a/qmljs_objects.cpp
+++ b/qmljs_objects.cpp
@@ -1120,10 +1120,10 @@ RegExpObject::RegExpObject(ExecutionEngine *engine, PassRefPtr<RegExp> value, bo
     lastIndexProperty->value = Value::fromInt32(0);
     if (!this->value.get())
         return;
-    defineDefaultProperty(engine->identifier(QStringLiteral("source")), Value::fromString(engine->newString(this->value->pattern())));
-    defineDefaultProperty(engine->identifier(QStringLiteral("global")), Value::fromBoolean(global));
-    defineDefaultProperty(engine->identifier(QStringLiteral("ignoreCase")), Value::fromBoolean(this->value->ignoreCase()));
-    defineDefaultProperty(engine->identifier(QStringLiteral("multiline")), Value::fromBoolean(this->value->multiLine()));
+    defineReadonlyProperty(engine->identifier(QStringLiteral("source")), Value::fromString(engine->newString(this->value->pattern())));
+    defineReadonlyProperty(engine->identifier(QStringLiteral("global")), Value::fromBoolean(global));
+    defineReadonlyProperty(engine->identifier(QStringLiteral("ignoreCase")), Value::fromBoolean(this->value->ignoreCase()));
+    defineReadonlyProperty(engine->identifier(QStringLiteral("multiline")), Value::fromBoolean(this->value->multiLine()));
 }
 
 ErrorObject::ErrorObject(ExecutionEngine* engine, const Value &message)

diff --git a/tests/TestExpectations b/tests/TestExpectations
index a125833..5d7b573 100644 (file)
--- a/tests/TestExpectations
+++ b/tests/TestExpectations
@@ -311,18 +311,6 @@ S15.10.2.12_A5_T1 failing
 S15.10.2.8_A3_T18 failing
 S15.10.6.2_A1_T2 failing
 S15.10.7_A2_T1 failing
-15.10.7.1-2 failing
-S15.10.7.1_A10 failing
-S15.10.7.1_A9 failing
-15.10.7.2-2 failing
-S15.10.7.2_A10 failing
-S15.10.7.2_A9 failing
-15.10.7.3-2 failing
-S15.10.7.3_A10 failing
-S15.10.7.3_A9 failing
-15.10.7.4-2 failing
-S15.10.7.4_A10 failing
-S15.10.7.4_A9 failing
 S15.11.4.2_A1 failing
 S15.11.4.2_A2 failing
 15.12.1.1-g6-3 failing
@@ -1190,4 +1178,4 @@ S15.4.4.4_A1_T2 failing
 
 15.4.4.21-8-b-iii-1-6 failing
 15.12.3_4-1-1
-15.12.3_4-1-3
+15.12.3_4-1-3
\ No newline at end of file