Improve qtconcurrentthreadengine autotest.
authorJason McDonald <jason.mcdonald@nokia.com>
Fri, 23 Dec 2011 05:18:16 +0000 (15:18 +1000)
committerQt by Nokia <qt-info@nokia.com>
Wed, 28 Dec 2011 05:34:15 +0000 (06:34 +0100)
The threadCount() test function is unstable and had been disabled by
making it not be a slot.  It is better to disable it with QSKIP so that
the test output shows that the test function exists and is in need of
repair.

Change-Id: Iccdc8da31e0d15d922f7e9606835d1ff1a3a4966
Reviewed-by: Rohan McGovern <rohan.mcgovern@nokia.com>
tests/auto/corelib/concurrent/qtconcurrentthreadengine/tst_qtconcurrentthreadengine.cpp

index e020190..d1350ba 100644 (file)
@@ -48,14 +48,13 @@ using namespace QtConcurrent;
 class tst_QtConcurrentThreadEngine: public QObject
 {
     Q_OBJECT
-public:
-    void threadCount();
 private slots:
     void runDirectly();
     void result();
     void runThroughStarter();
     void cancel();
     void throttle();
+    void threadCount();
     void multipleResults();
     void stresstest();
     void cancelQueuedSlowUser();
@@ -279,6 +278,8 @@ public:
 
 void tst_QtConcurrentThreadEngine::threadCount()
 {
+    QSKIP("QTBUG-23333: This test is unstable");
+
     const int repeats = 10;
     for (int i = 0; i < repeats; ++i) {
         ThreadCountUser t;