[Ada] Ineffective use warning is suppressed when performing verification

This patch fixes an issue whereby the compiler incorrectly marked use clauses
as effective due to code generated for verification referencing certain types
leading to missing use clause warnings.

No reasonably small testcase available.

2018-05-24  Justin Squirek  <squirek@adacore.com>

gcc/ada/

	* sem_res.adb (Resolve_Entity_Name): Add guard to protect against
	marking use clauses as effective when the reference appears within
	generated code.

From-SVN: r260652

diff --git a/gcc/ada/ChangeLog b/gcc/ada/ChangeLog
index ae9c071..6707a1a 100644 (file)
--- a/gcc/ada/ChangeLog
+++ b/gcc/ada/ChangeLog
@@ -1,3 +1,9 @@
+2018-05-24  Justin Squirek  <squirek@adacore.com>
+
+       * sem_res.adb (Resolve_Entity_Name): Add guard to protect against
+       marking use clauses as effective when the reference appears within
+       generated code.
+
 2018-05-24  Cyrille Comar  <comar@adacore.com>
 
        * doc/gnat_rm/the_gnat_library.rst: Fix typos.

diff --git a/gcc/ada/sem_res.adb b/gcc/ada/sem_res.adb
index e7ee70e..f6caccc 100644 (file)
--- a/gcc/ada/sem_res.adb
+++ b/gcc/ada/sem_res.adb
@@ -7293,7 +7293,13 @@ package body Sem_Res is
          end if;
       end if;
 
-      Mark_Use_Clauses (E);
+      --  We may be resolving an entity within expanded code, so a reference
+      --  to an entity should be ignored when calculating effective use clauses
+      --  to avoid inappropriate marking.
+
+      if Comes_From_Source (N) then
+         Mark_Use_Clauses (E);
+      end if;
    end Resolve_Entity_Name;
 
    -------------------