EDAC/amd64: Set grain per DIMM
authorYazen Ghannam <yazen.ghannam@amd.com>
Tue, 22 Oct 2019 20:35:14 +0000 (20:35 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 31 Dec 2019 15:44:20 +0000 (16:44 +0100)
[ Upstream commit 466503d6b1b33be46ab87c6090f0ade6c6011cbc ]

The following commit introduced a warning on error reports without a
non-zero grain value.

  3724ace582d9 ("EDAC/mc: Fix grain_bits calculation")

The amd64_edac_mod module does not provide a value, so the warning will
be given on the first reported memory error.

Set the grain per DIMM to cacheline size (64 bytes). This is the current
recommendation.

Fixes: 3724ace582d9 ("EDAC/mc: Fix grain_bits calculation")
Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
Signed-off-by: Borislav Petkov <bp@suse.de>
Cc: "linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Cc: James Morse <james.morse@arm.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: Robert Richter <rrichter@marvell.com>
Cc: Tony Luck <tony.luck@intel.com>
Link: https://lkml.kernel.org/r/20191022203448.13962-7-Yazen.Ghannam@amd.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/edac/amd64_edac.c

index c1d4536..cc5e56d 100644 (file)
@@ -2936,6 +2936,7 @@ static int init_csrows_df(struct mem_ctl_info *mci)
                        dimm->mtype = pvt->dram_type;
                        dimm->edac_mode = edac_mode;
                        dimm->dtype = dev_type;
+                       dimm->grain = 64;
                }
        }
 
@@ -3012,6 +3013,7 @@ static int init_csrows(struct mem_ctl_info *mci)
                        dimm = csrow->channels[j]->dimm;
                        dimm->mtype = pvt->dram_type;
                        dimm->edac_mode = edac_mode;
+                       dimm->grain = 64;
                }
        }