Re-deprecate $[

This was something e1dccc0d3 removed that b82b06b8 failed to restore.

diff --git a/ext/arybase/arybase.xs b/ext/arybase/arybase.xs
index 765b1eb..d654b54 100644 (file)
--- a/ext/arybase/arybase.xs
+++ b/ext/arybase/arybase.xs
@@ -162,6 +162,9 @@ STATIC void ab_process_assignment(pTHX_ OP *left, OP *right) {
  if (ab_op_is_dollar_bracket(left) && right->op_type == OP_CONST) {
   set_arybase_to(SvIV(cSVOPx_sv(right)));
   ab_neuter_dollar_bracket(left);
+  Perl_ck_warner_d(aTHX_
+   packWARN(WARN_DEPRECATED), "Use of assignment to $[ is deprecated"
+  );
  }
 }
 

diff --git a/ext/arybase/t/aeach.t b/ext/arybase/t/aeach.t
index f56d39e..241677a 100644 (file)
--- a/ext/arybase/t/aeach.t
+++ b/ext/arybase/t/aeach.t
@@ -1,4 +1,4 @@
-use warnings;
+use warnings; no warnings 'deprecated';
 use strict;
 
 BEGIN {

diff --git a/ext/arybase/t/aelem.t b/ext/arybase/t/aelem.t
index d6b8c38..c26a2a8 100644 (file)
--- a/ext/arybase/t/aelem.t
+++ b/ext/arybase/t/aelem.t
@@ -1,4 +1,4 @@
-use warnings;
+use warnings; no warnings 'deprecated';
 use strict;
 
 use Test::More tests => 33;

diff --git a/ext/arybase/t/akeys.t b/ext/arybase/t/akeys.t
index 45af13b..53e9db1 100644 (file)
--- a/ext/arybase/t/akeys.t
+++ b/ext/arybase/t/akeys.t
@@ -1,4 +1,4 @@
-use warnings;
+use warnings; no warnings 'deprecated';
 use strict;
 
 BEGIN {

diff --git a/ext/arybase/t/arybase.t b/ext/arybase/t/arybase.t
index a7edaf4..f3d3287 100644 (file)
--- a/ext/arybase/t/arybase.t
+++ b/ext/arybase/t/arybase.t
@@ -3,6 +3,7 @@
 # Basic tests for $[ as a variable
 # plus miscellaneous bug fix tests
 
+no warnings 'deprecated';
 use Test::More tests => 7;
 
 sub outside_base_scope { return "${'['}" }

diff --git a/ext/arybase/t/aslice.t b/ext/arybase/t/aslice.t
index 38aa87b..f4a507d 100644 (file)
--- a/ext/arybase/t/aslice.t
+++ b/ext/arybase/t/aslice.t
@@ -1,4 +1,4 @@
-use warnings;
+use warnings; no warnings 'deprecated';
 use strict;
 
 use Test::More tests => 18;

diff --git a/ext/arybase/t/av2arylen.t b/ext/arybase/t/av2arylen.t
index 988cca9..6c1deb2 100644 (file)
--- a/ext/arybase/t/av2arylen.t
+++ b/ext/arybase/t/av2arylen.t
@@ -1,4 +1,4 @@
-use warnings;
+use warnings; no warnings 'deprecated';
 use strict;
 
 use Test::More tests => 8;

diff --git a/ext/arybase/t/index.t b/ext/arybase/t/index.t
index 58efe74..86dde88 100644 (file)
--- a/ext/arybase/t/index.t
+++ b/ext/arybase/t/index.t
@@ -1,4 +1,4 @@
-use warnings;
+use warnings; no warnings 'deprecated';
 use strict;
 
 use Test::More tests => 12;

diff --git a/ext/arybase/t/lslice.t b/ext/arybase/t/lslice.t
index 6247a5e..c012b84 100644 (file)
--- a/ext/arybase/t/lslice.t
+++ b/ext/arybase/t/lslice.t
@@ -1,4 +1,4 @@
-use warnings;
+use warnings; no warnings 'deprecated';
 use strict;
 
 use Test::More tests => 11;

diff --git a/ext/arybase/t/pos.t b/ext/arybase/t/pos.t
index f2f6504..970e17e 100644 (file)
--- a/ext/arybase/t/pos.t
+++ b/ext/arybase/t/pos.t
@@ -1,4 +1,4 @@
-use warnings;
+use warnings; no warnings 'deprecated';
 use strict;
 
 use Test::More tests => 12;

diff --git a/ext/arybase/t/scope.t b/ext/arybase/t/scope.t
index 5fb0993..07b4176 100644 (file)
--- a/ext/arybase/t/scope.t
+++ b/ext/arybase/t/scope.t
@@ -1,4 +1,4 @@
-use warnings;
+use warnings; no warnings 'deprecated';
 use strict;
 
 use Test::More tests => 14;

diff --git a/ext/arybase/t/splice.t b/ext/arybase/t/splice.t
index e2db280..9fd618a 100644 (file)
--- a/ext/arybase/t/splice.t
+++ b/ext/arybase/t/splice.t
@@ -1,4 +1,4 @@
-use warnings;
+use warnings; no warnings 'deprecated';
 use strict;
 
 use Test::More tests => 23;

diff --git a/ext/arybase/t/substr.t b/ext/arybase/t/substr.t
index 793293b..ecfba48 100644 (file)
--- a/ext/arybase/t/substr.t
+++ b/ext/arybase/t/substr.t
@@ -1,4 +1,4 @@
-use warnings;
+use warnings; no warnings 'deprecated';
 use strict;
 
 use Test::More tests => 6;

diff --git a/pod/perldiag.pod b/pod/perldiag.pod
index 20ee641..594d58a 100644 (file)
--- a/pod/perldiag.pod
+++ b/pod/perldiag.pod
@@ -5147,6 +5147,11 @@ you can write it as C<push(@tied_array,())> to avoid this warning.
 (F) The "use" keyword is recognized and executed at compile time, and
 returns no useful value.  See L<perlmod>.
 
+=item Use of assignment to $[ is deprecated
+
+(D deprecated) The C<$[> variable (index of the first element in an array)
+is deprecated. See L<perlvar/"$[">.
+
 =item Use of bare << to mean <<"" is deprecated
 
 (D deprecated) You are now encouraged to use the explicitly quoted

diff --git a/t/lib/warnings/op b/t/lib/warnings/op
index 7f00838..3797b38 100644 (file)
--- a/t/lib/warnings/op
+++ b/t/lib/warnings/op
@@ -1171,6 +1171,21 @@ Deprecated use of my() in false conditional at - line 7.
 Deprecated use of my() in false conditional at - line 8.
 ########
 # op.c
+$[ = 1;
+($[) = 1;
+use warnings 'deprecated';
+$[ = 2;
+($[) = 2;
+no warnings 'deprecated';
+$[ = 3;
+($[) = 3;
+EXPECT
+Use of assignment to $[ is deprecated at - line 2.
+Use of assignment to $[ is deprecated at - line 3.
+Use of assignment to $[ is deprecated at - line 5.
+Use of assignment to $[ is deprecated at - line 6.
+########
+# op.c
 use warnings 'void';
 @x = split /y/, "z";
 $x = split /y/, "z";

diff --git a/t/op/array_base.t b/t/op/array_base.t
index fe5045a..34404d4 100644 (file)
--- a/t/op/array_base.t
+++ b/t/op/array_base.t
@@ -1,5 +1,6 @@
 #!perl -w
 use strict;
+no warnings 'deprecated';
 
 BEGIN {
  require './test.pl';