Input: gpio-keys - remove extra call to input_sync
authorPaul Cercueil <paul@crapouillou.net>
Sun, 21 Mar 2021 23:06:23 +0000 (16:06 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 25 Mar 2021 18:14:08 +0000 (11:14 -0700)
The input_sync() function is already called after the loop in
gpio_keys_report_state(), so it does not need to be called after each
iteration within gpio_keys_gpio_report_event().

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Link: https://lore.kernel.org/r/20210307222240.380583-1-paul@crapouillou.net
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/gpio_keys.c

index 77bac4d..7fcb2c3 100644 (file)
@@ -373,7 +373,6 @@ static void gpio_keys_gpio_report_event(struct gpio_button_data *bdata)
        } else {
                input_event(input, type, *bdata->code, state);
        }
-       input_sync(input);
 }
 
 static void gpio_keys_gpio_work_func(struct work_struct *work)
@@ -382,6 +381,7 @@ static void gpio_keys_gpio_work_func(struct work_struct *work)
                container_of(work, struct gpio_button_data, work.work);
 
        gpio_keys_gpio_report_event(bdata);
+       input_sync(bdata->input);
 
        if (bdata->button->wakeup)
                pm_relax(bdata->input->dev.parent);