Coverity Issues FIx

Change-Id: I4a5fc82ffcfe719bae65aae56f8a8dd301205ad4

diff --git a/server/src/ClientListener.cpp b/server/src/ClientListener.cpp
index 41eb25bf4e4bdd34b519b9f6a0f08cc4744f9fcd..770fb201f80735e5c9082a9e1797aa0f3d4675ba 100755 (executable)
--- a/server/src/ClientListener.cpp
+++ b/server/src/ClientListener.cpp
@@ -97,7 +97,7 @@ ClientListner::readProc(const char *path, char *buf, int size)
        if (ret <= 0) {
                _ERR("fd read error(%d)\n", fd);
 
-               if (close(fd) == -1);
+               if (close(fd) == -1)
                        _ERR("fd close error");
 
                return -1;

diff --git a/silent_auth/silent_auth_entry.cpp b/silent_auth/silent_auth_entry.cpp
index 6661e928c429e10efce0ae5065ba11adc055be19..abd8137289a207828fa560b6ccb04654fdba192f 100755 (executable)
--- a/silent_auth/silent_auth_entry.cpp
+++ b/silent_auth/silent_auth_entry.cpp
@@ -867,6 +867,23 @@ processRegister(unsigned char *assert_req)
                _INFO("encode EID_UAFV1_REG_ASSERTION_KRD_RESP PASS, length of encoded UAFV1KRD is = [%d]", uafv1KrdBuff->len);
        } else {
                _ERR("encode EID_UAFV1_REG_ASSERTION_KRD_RESP FAIL");
+               SAFE_DELETE(getRegRespInfo->kh->data);
+               SAFE_DELETE(getRegRespInfo->kh);
+
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->aaid);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->assrtInfo);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->fch->data);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->fch);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->keyId->data);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->keyId);
+
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->counter);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->pubKey->data);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->pubKey);
+
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd);
+               SAFE_DELETE(getRegRespInfo->regAssertion);
+
                SAFE_DELETE(getRegRespInfo);
                SAFE_DELETE(priv_key_b64_enc);
                SAFE_DELETE(keyId_b64_enc);
@@ -924,7 +941,30 @@ processRegister(unsigned char *assert_req)
        } else {
                _INFO("setEncoder EID_UAFV1_REGISTER_RESP FAIL \n");
                SAFE_DELETE(krdStr);
+               SAFE_DELETE(getRegRespInfo->kh->data);
                SAFE_DELETE(getRegRespInfo->kh);
+
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->aaid);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->assrtInfo);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->fch->data);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->fch);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->keyId->data);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->keyId);
+
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->counter);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->pubKey->data);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->pubKey);
+
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd);
+
+
+               SAFE_DELETE(getRegRespInfo->regAssertion->attFull->sig->data);
+               SAFE_DELETE(getRegRespInfo->regAssertion->attFull->sig);
+               SAFE_DELETE(getRegRespInfo->regAssertion->attFull->cert->data);
+               SAFE_DELETE(getRegRespInfo->regAssertion->attFull->cert);
+               SAFE_DELETE(getRegRespInfo->regAssertion->attFull);
+               SAFE_DELETE(getRegRespInfo->regAssertion);
+
                SAFE_DELETE(getRegRespInfo);
                return NULL;
        }
@@ -935,6 +975,28 @@ processRegister(unsigned char *assert_req)
        } else {
                _INFO("decode EID_UAFV1_REGISTER_RESP FAIL \n");
                SAFE_DELETE(krdStr);
+               SAFE_DELETE(getRegRespInfo->kh->data);
+               SAFE_DELETE(getRegRespInfo->kh);
+
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->aaid);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->assrtInfo);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->fch->data);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->fch);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->keyId->data);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->keyId);
+
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->counter);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->pubKey->data);
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd->pubKey);
+
+               SAFE_DELETE(getRegRespInfo->regAssertion->krd);
+
+               SAFE_DELETE(getRegRespInfo->regAssertion->attFull->sig->data);
+               SAFE_DELETE(getRegRespInfo->regAssertion->attFull->sig);
+               SAFE_DELETE(getRegRespInfo->regAssertion->attFull->cert->data);
+               SAFE_DELETE(getRegRespInfo->regAssertion->attFull->cert);
+               SAFE_DELETE(getRegRespInfo->regAssertion->attFull);
+               SAFE_DELETE(getRegRespInfo->regAssertion);
                SAFE_DELETE(getRegRespInfo);
                return NULL;
        }