staging: rtl8192e: Remove unused variables rxcrcerrmin and friends
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Wed, 25 Jan 2023 20:08:40 +0000 (21:08 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jan 2023 09:12:04 +0000 (10:12 +0100)
rxcrcerrmin, rxcrcerrmax and rxcrcerrmid are initialized and increased
but never read. Remove dead code.

Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/4c791fbb3559ce15de60b7bdcabbc50b0ee9adb9.1674675808.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
drivers/staging/rtl8192e/rtl8192e/rtl_core.h

index 9260d30..e9273df 100644 (file)
@@ -1812,7 +1812,6 @@ static void _rtl92e_update_received_rate_histogram_stats(
 bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
                         struct rx_desc *pdesc, struct sk_buff *skb)
 {
-       struct r8192_priv *priv = rtllib_priv(dev);
        struct rx_fwinfo *pDrvInfo = NULL;
 
        stats->bICV = pdesc->ICV;
@@ -1825,15 +1824,6 @@ bool rtl92e_get_rx_stats(struct net_device *dev, struct rtllib_rx_stats *stats,
 
        if (stats->bHwError) {
                stats->bShift = false;
-
-               if (pdesc->CRC32) {
-                       if (pdesc->Length < 500)
-                               priv->stats.rxcrcerrmin++;
-                       else if (pdesc->Length > 1000)
-                               priv->stats.rxcrcerrmax++;
-                       else
-                               priv->stats.rxcrcerrmid++;
-               }
                return false;
        }
 
index f91a6f7..167c4ae 100644 (file)
@@ -183,9 +183,6 @@ enum reset_type {
 };
 
 struct rt_stats {
-       unsigned long rxcrcerrmin;
-       unsigned long rxcrcerrmid;
-       unsigned long rxcrcerrmax;
        unsigned long received_rate_histogram[4][32];
        unsigned long received_preamble_GI[2][32];
        unsigned long numpacket_matchbssid;